After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680706 - Segfault on directsoundsink when AC3 support is tested after the DirectSound buffer is created
Segfault on directsoundsink when AC3 support is tested after the DirectSound ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.36
Other Windows
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-27 14:29 UTC by Xavi Artigas
Modified: 2012-08-06 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not overwrite DS buffer when testing for AC3 support (1013 bytes, patch)
2012-07-27 14:29 UTC, Xavi Artigas 		committed Details | Review

Description Xavi Artigas 2012-07-27 14:29:45 UTC 
Created attachment 219741 [details] [review]
Do not overwrite DS buffer when testing for AC3 support

Right now, the gst_directsound_probe_supported_formats function overwrites the dsoundsink->pDSBSecondary variable, which is not a bad thing if it has not been used yet.
Under some circumstances, though, this method can be called when the DS buffer is already created and in use.

The attached patch uses a temporary variable to hold the test buffer, and leaves the sink's own buffer alone.

This fixes a segfault in DS for me when playing some DVDs.
Comment 1 Sebastian Dröge (slomo) 2012-08-06 08:54:25 UTC 
commit 417cbcf34f01f4d18c40094413143f483ad366f0
Author: Xavi Artigas <xartigas@fluendo.com>
Date:   Fri Jul 27 16:13:49 2012 +0200

    directsoundsink: Do not overwrite the DS buffer when testing for AC3 support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680706