GNOME Bugzilla – Bug 680402
gnucash-2.4.11: tests fails due unused translations
Last modified: 2018-06-29 23:09:39 UTC
I get: The usage of POTFILES.ignore is deprecated. Please consider moving the content of this file to POTFILES.skip. The following files contain translations and are currently not in use. Please consider adding these to the POTFILES.in file, located in the po/ directory. src/app-utils/date-utilities.scm src/app-utils/prefs.scm src/business/business-utils/business-prefs.scm src/business/business-utils/business-utils.scm src/business/business-utils/gnucash/business-utils.scm src/import-export/qif-import/qif-dialog-utils.scm src/import-export/qif-import/qif-file.scm src/import-export/qif-import/qif-import/qif-dialog-utils.scm src/import-export/qif-import/qif-import/qif-file.scm src/import-export/qif-import/qif-import/qif-merge-groups.scm src/import-export/qif-import/qif-import/qif-parse.scm src/import-export/qif-import/qif-import/qif-to-gnc.scm src/import-export/qif-import/qif-merge-groups.scm src/import-export/qif-import/qif-parse.scm src/import-export/qif-import/qif-to-gnc.scm src/report/business-reports/aging.scm src/report/business-reports/balsheet-eg.eguile.scm src/report/business-reports/balsheet-eg.scm src/report/business-reports/business-reports.scm src/report/business-reports/customer-summary.scm src/report/business-reports/easy-invoice.scm src/report/business-reports/fancy-invoice.scm src/report/business-reports/gnucash/report/aging.scm src/report/business-reports/gnucash/report/balsheet-eg.eguile.scm src/report/business-reports/gnucash/report/balsheet-eg.scm src/report/business-reports/gnucash/report/business-reports.scm src/report/business-reports/gnucash/report/customer-summary.scm src/report/business-reports/gnucash/report/easy-invoice.scm src/report/business-reports/gnucash/report/fancy-invoice.scm src/report/business-reports/gnucash/report/invoice.scm src/report/business-reports/gnucash/report/job-report.scm src/report/business-reports/gnucash/report/owner-report.scm src/report/business-reports/gnucash/report/payables.scm src/report/business-reports/gnucash/report/receivables.scm src/report/business-reports/gnucash/report/taxinvoice.eguile.scm src/report/business-reports/gnucash/report/taxinvoice.scm src/report/business-reports/invoice.scm src/report/business-reports/job-report.scm src/report/business-reports/owner-report.scm src/report/business-reports/payables.scm src/report/business-reports/receivables.scm src/report/business-reports/taxinvoice.eguile.scm src/report/business-reports/taxinvoice.scm src/report/locale-specific/us/gnucash/report/taxtxf-de_DE.scm src/report/locale-specific/us/gnucash/report/taxtxf.scm src/report/locale-specific/us/taxtxf-de_DE.scm src/report/locale-specific/us/taxtxf.scm src/report/report-gnome/gnucash/report/report-gnome.scm src/report/report-gnome/report-gnome.scm src/report/report-system/eguile-gnc.scm src/report/report-system/gnucash/report/eguile-gnc.scm src/report/report-system/html-acct-table.scm src/report/report-system/html-fonts.scm src/report/report-system/html-style-sheet.scm src/report/report-system/html-utilities.scm src/report/report-system/options-utilities.scm src/report/report-system/report-utilities.scm src/report/report-system/report.scm src/report/standard-reports/account-piecharts.scm src/report/standard-reports/account-summary.scm src/report/standard-reports/advanced-portfolio.scm src/report/standard-reports/average-balance.scm src/report/standard-reports/balance-sheet.scm src/report/standard-reports/budget-balance-sheet.scm src/report/standard-reports/budget-barchart.scm src/report/standard-reports/budget-flow.scm src/report/standard-reports/budget-income-statement.scm src/report/standard-reports/budget.scm src/report/standard-reports/cash-flow.scm src/report/standard-reports/category-barchart.scm src/report/standard-reports/daily-reports.scm src/report/standard-reports/equity-statement.scm src/report/standard-reports/general-journal.scm src/report/standard-reports/general-ledger.scm src/report/standard-reports/gnucash/report/standard-reports/account-piecharts.scm src/report/standard-reports/gnucash/report/standard-reports/account-summary.scm src/report/standard-reports/gnucash/report/standard-reports/advanced-portfolio.scm src/report/standard-reports/gnucash/report/standard-reports/average-balance.scm src/report/standard-reports/gnucash/report/standard-reports/balance-sheet.scm src/report/standard-reports/gnucash/report/standard-reports/budget-balance-sheet.scm src/report/standard-reports/gnucash/report/standard-reports/budget-barchart.scm src/report/standard-reports/gnucash/report/standard-reports/budget-flow.scm src/report/standard-reports/gnucash/report/standard-reports/budget-income-statement.scm src/report/standard-reports/gnucash/report/standard-reports/budget.scm src/report/standard-reports/gnucash/report/standard-reports/cash-flow.scm src/report/standard-reports/gnucash/report/standard-reports/category-barchart.scm src/report/standard-reports/gnucash/report/standard-reports/daily-reports.scm src/report/standard-reports/gnucash/report/standard-reports/equity-statement.scm src/report/standard-reports/gnucash/report/standard-reports/general-journal.scm src/report/standard-reports/gnucash/report/standard-reports/general-ledger.scm src/report/standard-reports/gnucash/report/standard-reports/income-statement.scm src/report/standard-reports/gnucash/report/standard-reports/net-barchart.scm src/report/standard-reports/gnucash/report/standard-reports/net-linechart.scm src/report/standard-reports/gnucash/report/standard-reports/portfolio.scm src/report/standard-reports/gnucash/report/standard-reports/price-scatter.scm src/report/standard-reports/gnucash/report/standard-reports/register.scm src/report/standard-reports/gnucash/report/standard-reports/sx-summary.scm src/report/standard-reports/gnucash/report/standard-reports/transaction.scm src/report/standard-reports/gnucash/report/standard-reports/trial-balance.scm src/report/standard-reports/income-statement.scm src/report/standard-reports/net-barchart.scm src/report/standard-reports/net-linechart.scm src/report/standard-reports/portfolio.scm src/report/standard-reports/price-scatter.scm src/report/standard-reports/register.scm src/report/standard-reports/sx-summary.scm src/report/standard-reports/transaction.scm src/report/standard-reports/trial-balance.scm src/report/stylesheets/gnucash/report/stylesheet-easy.scm src/report/stylesheets/gnucash/report/stylesheet-fancy.scm src/report/stylesheets/gnucash/report/stylesheet-footer.scm src/report/stylesheets/gnucash/report/stylesheet-plain.scm src/report/stylesheets/stylesheet-easy.scm src/report/stylesheets/stylesheet-fancy.scm src/report/stylesheets/stylesheet-footer.scm src/report/stylesheets/stylesheet-plain.scm src/report/utility-reports/gnucash/report/hello-world.scm src/report/utility-reports/gnucash/report/view-column.scm src/report/utility-reports/gnucash/report/welcome-to-gnucash.scm src/report/utility-reports/hello-world.scm src/report/utility-reports/view-column.scm src/report/utility-reports/welcome-to-gnucash.scm src/scm/build-config.scm src/scm/build-config.scm.in src/scm/command-line.scm src/scm/gnucash/price-quotes.scm src/scm/main-window.scm src/scm/price-quotes.scm src/tax/us/de_DE.scm src/tax/us/gnucash/tax/de_DE.scm src/tax/us/txf-de_DE.scm src/tax/us/txf.scm If some of these files are left out on purpose then please add them to POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list of left out files has been written in the current directory. Please report to gnucash-devel@gnucash.org if [ -r missing -o -r notexist ]; then \ exit 1; \ fi make[1]: *** [check] Error 1 make[1]: Leaving directory `/var/tmp/portage/app-office/gnucash-2.4.11/work/gnucash-2.4.11/po' make: *** [check-recursive] Error 1
Hi, We need MUCH more information in order to attempt to reproduce this. What exact version of GnuCash are you trying to build? What OS/Distro are you using? What version of intltool? What configure options? What Make rule did you run?
(In reply to comment #1) > Hi, > > We need MUCH more information in order to attempt to reproduce this. > > What exact version of GnuCash are you trying to build? 2.4.11 > What OS/Distro are you using? Gentoo > What version of intltool? 0.50.2 > What configure options? ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking GUILE_LIBS= -pthread -L/usr/lib64 -lguile -lltdl -lgmp -lcrypt -lm -lltdl --with-html-engine=webkit --disable-dbi --enable-gtkmm --disable-debug --disable-ofx --disable-aqbanking --enable-python-bindings --disable-doxygen --enable-locale-specific-tax --disable-error-on-warning > What Make rule did you run? make check in main sources directory
Created attachment 219419 [details] build.log.bz2 Full build.log
Also, are you building from the tarball or pulling from Subversion?
(In reply to comment #2) > (In reply to comment #1) > > > > What exact version of GnuCash are you trying to build? > > 2.4.11 Then why did you change the version to SVN?
The build log shows he's building from the tarball, which of course passed distcheck as part of doing the release. As a first-order guess, whatever xgettext he's using doesn't know how to extract the strings from scheme files.
Okay, so what version of the gettext package? I thought we shipped our own xgettext because of this? Or did we stop because they finally started supporting it natively? I'm trying to remember.
No, I guessed backwards: Our xgettext workaround extracts all of the translatable strings from scheme files into a c file, guile-strings.c, which we can then run xgettext on. The problem would seem to be that xgettext or intltool-update (which may run xgettext, I don't know the internals) actually *is* picking up the translation strings in scheme file.
(In reply to comment #4) > Also, are you building from the tarball or pulling from Subversion? tarball (In reply to comment #5) > (In reply to comment #2) > > (In reply to comment #1) > > > > > > What exact version of GnuCash are you trying to build? > > > > 2.4.11 > > Then why did you change the version to SVN? Because bugzilla is missing 2.4.11 version, and I thought SVN was more near to 2.4.11 than 2.4.10 (In reply to comment #7) > Okay, so what version of the gettext package? > > I thought we shipped our own xgettext because of this? Or did we stop because > they finally started supporting it natively? I'm trying to remember. gettext-0.18.1.1
Ok, so the problem is that his build from tarball tries to be more intelligent than it should be. Our intltool/gettext version during tarball creation and distcheck accepted our configuration, but the tools at the user's computer did not. In our opinion, the user's computer shouldn't check those files anyway, as that's the job of the tarball creation. Now, who should change something here?
In that case, maybe the test for checking that shouldn't be enabled in tarballs to prevent people from running it when running "make check" :/
Intltool scans Scheme files from version 0.50, and Fedora 17, Debian Wheezy (testing), and probably others besides Gentoo are shipping that version. po/Makefile.in.in, which generates the test, is created by intltoolize. If we make po a DIST_SUBDIR then make install won't install the localizations, so that's no good either. I think the simplest solution is to add all of the scheme files to POTFILES.skip. Older versions of intltool won't care and make check will pass on newer ones. I'll have to remember to use a Debian testing or Fedora 17 VM for making the tarballs, though, so that make distcheck will flag any new scheme files.
Hi John, I try to reformulate the state of Bug 619899 - Use normal gettext or intltool toolchain also for scm files: I was 2010 able to get a comparable result as our xgettext with SCMFILES = $(shell find ${abs_top_srcdir}/src -name-type l -prune test -prune -o -name '*.scm' -print ) and after the normal $(XGETTEXT) for C files etc. $(XGETTEXT) --join-existing --add-comments --keyword=Q_ --keyword=N_ --keyword=_ --flag=_:1:pass-scheme-format $(SCMFILES) As Geert worked out: 1. intltool (0.41.1-1.fc14.noarch) seems to think scm files are some xml dialect. - explains, why I had to add the flag 2. "N_ " isn't recognized, "N_" is though. - that's why I had to add the keywords Both should be fixed in intltools 0.50 Further improvements enabled by a switch to intltool: --add-comments: is an improvement for the translators. -name-type l -prune: remove the annoying duplicates by linked directories So I think we could also now get rid of xgettext.scm.
> So I think we could also now get rid of xgettext.scm. Not until intltool 0.50.x (or later,of course) is in the current RHEL. Might be a while. ;-)
Scheme files added to POTFILES.skip: r22298 (trunk), r22300 (2.4).
(In reply to comment #14) > > So I think we could also now get rid of xgettext.scm. > > Not until intltool 0.50.x (or later,of course) is in the current RHEL. Might be > a while. ;-) Indeed, that's why bug 619899 is still open. Waiting for all distro's to switch to intltool 0.50.x. I don't think we have to wait for RHEL though. Current trunk won't work on RHEL 6 due to our choice for gtk 2.24. So we ignored RHEL 6 for our next major release 2.6. I guess by the time we are at 2.8, RHEL will surely already have updated their intltool version. The distro I'm waiting for to update is debian stable. As far as I can discover they are also still using intltool 0.41.x, and after RHEL the slowest distro to upgrade.
Follow-up at Bug 619899.
Agreed, it's too early to depend on intltool 0.50.x
Reassign version to 2.4.x so that individual 2.4 versions can be retired.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=680402. Please update any external references or bookmarks.