After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680291 - Avoid a warning at login
Avoid a warning at login
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-20 00:04 UTC by Matthias Clasen
Modified: 2012-07-27 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid a warning at login (1.75 KB, patch)
2012-07-20 00:04 UTC, Matthias Clasen 		none Details | Review
Updated patch (1.52 KB, patch)
2012-07-20 15:27 UTC, Olivier Fourdan 		accepted-commit_now Details | Review

Description Matthias Clasen 2012-07-20 00:04:30 UTC 
The wacom plugin calls init_screens before creating the devices
hash table in gsd_wacom_manager_idle_cb. init_screens connects to
the ::changed signal on GnomeRRScreens, and the signal handler
assumes that the devices hash table has been created. When we
are logging in, the ::changed signal is emitted before the idle
callback has a chance to run, causing a critical warning out
of g_hash_table_get_values.

Avoid that by creating the devices hash table before calling
init_screens.
Comment 1 Matthias Clasen 2012-07-20 00:04:32 UTC 
Created attachment 219283 [details] [review]
Avoid a warning at login
Comment 2 Olivier Fourdan 2012-07-20 15:25:46 UTC 
Review of attachment 219283 [details] [review]:

I would rather ignore the ::changed signal notification if the devices' hash table is not created yet
Comment 3 Olivier Fourdan 2012-07-20 15:27:25 UTC 
Created attachment 219331 [details] [review]
Updated patch

Would this be acceptable instead?
Comment 4 Matthias Clasen 2012-07-20 15:36:03 UTC 
Comment on attachment 219331 [details] [review]
Updated patch

sure, that works too
Comment 5 Bastien Nocera 2012-07-20 16:09:53 UTC 
Review of attachment 219331 [details] [review]:

Prefix the commit subject with "wacom:" and you're good.
Comment 6 Olivier Fourdan 2012-07-27 11:47:55 UTC 
Committed with "wacom:" added to the subject.