After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680200 - tsdemux: extract language-code of dvb subtitles into tags
tsdemux: extract language-code of dvb subtitles into tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.36
Other All
: Normal minor
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-18 19:32 UTC by Matthias Hardt
Modified: 2012-12-28 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to get dvb subtitle language codes in taglists (1.30 KB, patch)
2012-07-18 19:32 UTC, Matthias Hardt 		needs-work Details | Review
Former patch reworked (1.57 KB, patch)
2012-07-26 18:43 UTC, Matthias Hardt 		committed Details | Review

Description Matthias Hardt 2012-07-18 19:32:31 UTC 
Created attachment 219155 [details] [review]
Patch to get dvb subtitle language codes in taglists

To match the behaviour of mpegtsdemux, dvb subtitle language codes should also be sent as taglists.
Comment 1 Sebastian Dröge (slomo) 2012-07-23 10:10:55 UTC 
Comment on attachment 219155 [details] [review]
Patch to get dvb subtitle language codes in taglists

Looks good but could you attach it in "git format-patch" style and also change the comments to not include the MAH: part? :)
Comment 2 Matthias Hardt 2012-07-26 18:43:55 UTC 
Created attachment 219709 [details] [review]
Former patch reworked

Now in git-format-patch style without my comments.
Comment 3 Tim-Philipp Müller 2012-12-28 23:58:56 UTC 
Thanks, and sorry for the delay.


commit 0e3fdb1e167dfce394ef4cc0c5005ec2334b7ad2
Author: Matthias Hardt <mhardt@berlinux-solutions.de>
Date:   Thu Jul 26 20:38:28 2012 +0200

    tsdemux: extract ISO 639 language codes for subtitles into taglists
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680200