After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680181 - Fix misleading GST_WARNING in gst_poll_add_fd_unlocked
Fix misleading GST_WARNING in gst_poll_add_fd_unlocked
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-18 15:56 UTC by Sebastian Rasmussen
Modified: 2012-07-23 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch improving misleading debug warning. (735 bytes, patch)
2012-07-18 15:58 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2012-07-18 15:56:47 UTC 
When calling gst_poll_add_fd_unlocked() twice for the same fd and fdset while having GST_DEBUG=3 I see this error:

GST_POLL gstreamer/gst/gstpoll.c:767:gst_poll_add_fd_unlocked: 0x595240: couldn't find fd !

After looking through the code I observe that the message introduced by dc3fb58a904f25f87fd2c6b4501af773f202d2a9 is misleading, actually it ought to say that the fd has already been added.
Comment 1 Sebastian Rasmussen 2012-07-18 15:58:47 UTC 
Created attachment 219133 [details] [review]
Patch improving misleading debug warning.
Comment 2 Sebastian Dröge (slomo) 2012-07-23 10:12:01 UTC 
commit d24a5ecb933fd016de9cd6b863306d9bd2b6323e
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed Jul 18 17:03:45 2012 +0200

    gstpoll: Improve warning message when re-adding fd to fdset
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=680181