After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680065 - treemodelfilter: Make the constructor binding friendly
treemodelfilter: Make the constructor binding friendly
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-07-17 00:42 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-05 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
treemodelfilter: Make the constructor binding friendly (2.07 KB, patch)
2012-07-17 00:42 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-17 00:42:37 UTC 
See patch. There's tons of these all over the stack, but we'll never get anywhere unless we start somewhere.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-17 00:42:39 UTC 
Created attachment 218960 [details] [review]
treemodelfilter: Make the constructor binding friendly

This means reffing the root in the set property implementation,
rather than in the constructor. We don't need to unref the root
on set, as it's a CONSTRUCT_ONLY property.
Comment 2 Colin Walters 2012-12-05 18:38:37 UTC 
Review of attachment 218960 [details] [review]:

Looks correct.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-05 19:01:07 UTC 
Attachment 218960 [details] pushed as 7ee5e7a - treemodelfilter: Make the constructor binding friendly