GNOME Bugzilla – Bug 679919
[new roster] Rename a group?
Last modified: 2018-05-22 15:37:49 UTC
It seems that Empathy doesn't support renaming a group. Empathy 3.4.2.3-1 Will it be supported?
Better steps and information welcome, e.g. type of group... Bug 501065 was fixed in April before 3.4.2.3-1 was released, but I don't know if it was only fixed in unstable 3.5.x or also backported to stable 3.4.x.
Sorry. I don't search before posting this. 3.4.x seems that doesn't have this patch. OK. Just wait for 3.5.x. *** This bug has been marked as a duplicate of bug 501065 ***
Actually we didn't re-implement this feature in the new roster yet.
Humm this is going to be tricky to implement. From an UI pov I guess we should - right click on the group name, - have a context dialog and choose "edit" - the group label turns to an entry allowing you to change the name of the group - hit enter and it goes back to the updated label AFAIK GtkExpander doesn't allow us to do such thing easily. :\
Would this require creating our own subclass of GtkExpander which allows us to do this?
*** Bug 680910 has been marked as a duplicate of this bug. ***
I am working on it. While we will be able to change a group's name, the icon associated with the group will remain the same. Does that sound ok?
(In reply to comment #4) > Humm this is going to be tricky to implement. From an UI pov I guess we should > - right click on the group name, > - have a context dialog and choose "edit" > - the group label turns to an entry allowing you to change the name of the > group > - hit enter and it goes back to the updated label > > AFAIK GtkExpander doesn't allow us to do such thing easily. :\ While GtkExpander does not allow us to have it's label-widget receive button-press-event (or any event for that matter) on its children, a hack described in http://gtk.10911.n7.nabble.com/GtkExpander-label-widgets-using-buttons-as-td1738.html allowed me to make labels clickable inside a GtkExpander. I opened a gtk+ bug regarding this: https://bugzilla.gnome.org/show_bug.cgi?id=705971 I have a branch (https://gitorious.org/glassrose-gnome/empathy/commits/rename-a-group-679919) where I have deployed this hack to make the label clickable but this does not work in our case possibly because egg-list-box doesn't pass the event to its children (GtkExpander here).
The above branch works now with a second hack of unmapping and remapping the label-widget when the expander maps. This works! :) But there are some reordering issues cropped up which require some attention..
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/568.