After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679764 - Show information about web and plugin processes in about:memory
Show information about web and plugin processes in about:memory
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-07-11 18:34 UTC by Carlos Garcia Campos
Modified: 2012-08-14 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (5.84 KB, patch)
2012-07-11 18:35 UTC, Carlos Garcia Campos
reviewed Details | Review
Updated patch (5.87 KB, patch)
2012-08-14 06:58 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2012-07-11 18:34:20 UTC
When using WebKit2
Comment 1 Carlos Garcia Campos 2012-07-11 18:35:18 UTC
Created attachment 218582 [details] [review]
Patch
Comment 2 Xan Lopez 2012-08-02 13:50:52 UTC
Review of attachment 218582 [details] [review]:

Looks good, just a nitpick about the name of the main process.

::: lib/ephy-smaps.c
@@ +71,3 @@
+  switch (process) {
+  case EPHY_PROCESS_EPIPHANY:
+    return "Epiphany";

I suppose we should say Web here? Maybe that's confusing because there's a Web Process, so perhaps just say something like "UI Process". Dunno.
Comment 3 Xan Lopez 2012-08-02 15:01:52 UTC
Also, get_ephy_process_name () should be protected by #ifdef HAVE_WEBKIT2.
Comment 4 Carlos Garcia Campos 2012-08-14 06:58:55 UTC
Created attachment 221099 [details] [review]
Updated patch

Protected get_ephy_process_name with #ifdef and changed the process name to Browser instead of Epiphany. I think Epiphany is perfectly fine, fwiw.
Comment 5 Xan Lopez 2012-08-14 10:25:51 UTC
Review of attachment 221099 [details] [review]:

OK.