GNOME Bugzilla – Bug 679719
Add a recent files backend
Last modified: 2012-07-13 14:22:50 UTC
After discussing bug 325824 with Cosimo we thought it might be nice to implement this using a recent files backend.
Created attachment 218493 [details] [review] Add a recent files backend
Created attachment 218494 [details] [review] Enable more warnings with git
Review of attachment 218493 [details] [review]: Looks good otherwise, code is clean and readable. ::: configure.ac @@ +562,3 @@ +dnl **************************** + +PKG_CHECK_MODULES(GTK, [gtk+-3.0 >= 3.0]) Any dependency on gtk should be made conditional. GVfs can be very well used without gtk3 and outside Gnome.
Review of attachment 218494 [details] [review]: Btw. the --enable-more-warnings configure switch is disabled by default and it's not used in autogen.sh. The test logic just seems wrong, disabling warnings when explicitly asked for but no .git directory has been found? The messages about using -Werror are wrong the same way, it's not included in CFLAGS even when --enable-more-warnings is active. ::: configure.ac @@ +757,3 @@ set_more_warnings="$enableval",[ +if test -f $srcdir/.git; then + is_git_version=true is_{cvs,git}_version variable is not used anywhere, suggesting to remove it.
Created attachment 218566 [details] [review] Add a recent files backend Made dep conditional, added file delete support, better clean up at exit.
Review of attachment 218566 [details] [review]: A couple of quick things I saw in passing ::: daemon/gvfsbackendrecent.c @@ +633,3 @@ + + g_hash_table_destroy (backend->items); + g_hash_table_destroy (backend->uri_map); Need to clear the file monitors here as well. @@ +635,3 @@ + g_hash_table_destroy (backend->uri_map); + + g_signal_handlers_disconnect_by_func (backend->recent_manager, on_recent_manager_changed, backend); You don't seem to be chaining up to the parent finalize method.
Created attachment 218583 [details] [review] Add a recent files backend Addresses Cosimo's comments and uses a standard attribute for the real-uri instead of our own.
Review of attachment 218583 [details] [review]: Looks good to me, thanks for adding the extra configure check. Tested in nautilus, seems to be working fine, files can be read and deleted.
Created attachment 218729 [details] [review] Enable more warnings with git
Attachment 218583 [details] pushed as e3890dd - Add a recent files backend Attachment 218729 [details] pushed as 86137e5 - Enable more warnings with git