After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679715 - add an app menu
add an app menu
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks: 674957
 
 
Reported: 2012-07-10 22:28 UTC by Christian Persch
Modified: 2013-03-04 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port to GtkApplication (28.66 KB, patch)
2013-03-04 04:52 UTC, William Jon McCann 		none Details | Review
Add an app menu (12.07 KB, patch)
2013-03-04 04:52 UTC, William Jon McCann 		none Details | Review

Description Christian Persch 2012-07-10 22:28:53 UTC 
It's a gnome goal [https://live.gnome.org/GnomeGoals/PortToGMenu] that all apps define an app menu. 

However, since almost all distros are still using 3.2 due to not having guile 2.0, we can just delay this past 3.6 at least.

If anyone wants to work on this: I don't think aisleriot should be ported from GtkUIManager to GMenu at this point; it only needs to use GtkApplication (in *non-unique* mode!) and use GMenu for the app menu. The app menu should invoke the GtkActions on the aisleriot window, possibly using the adapter I've written for evince (bug 674937)
[http://git.gnome.org/browse/evince/commit/?h=wip/app&id=c72ba10280dcec7884d326fb271b67c661723e69].
Comment 1 William Jon McCann 2013-03-04 04:52:11 UTC 
Created attachment 237927 [details] [review]
Port to GtkApplication
Comment 2 William Jon McCann 2013-03-04 04:52:15 UTC 
Created attachment 237928 [details] [review]
Add an app menu
Comment 3 Christian Persch 2013-03-04 20:36:35 UTC 
Fixed on master (with some follow-up fixes and changes). Thanks!