After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679660 - Reduce amount of markup in translated messages
Reduce amount of markup in translated messages
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-10 03:14 UTC by Matthias Clasen
Modified: 2012-07-15 00:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.07 KB, patch)
2012-07-10 03:14 UTC, Matthias Clasen 		needs-work Details | Review
new patch (1.07 KB, patch)
2012-07-10 18:11 UTC, Matthias Clasen 		accepted-commit_now Details | Review
Reduce amount of markup in translated messages (1.12 KB, patch)
2012-07-15 00:47 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-07-10 03:14:47 UTC 
Created attachment 218377 [details] [review]
patch

Markup in messages is fragile and tends to break in translations.
This patch reduces the amount of markup as far as possible.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-10 03:41:16 UTC 
Review of attachment 218377 [details] [review]:

::: src/core/delete.c
@@ +111,3 @@
+    {
+      gchar *bold;
+      bold = g_strconcat ("<tt>, window_title, "</tt>", NULL);

Something tells me you didn't actually test this patch :)
Comment 2 Matthias Clasen 2012-07-10 18:11:02 UTC 
Created attachment 218454 [details] [review]
new patch

this one builds
Comment 3 drago01 2012-07-14 18:25:08 UTC 
Review of attachment 218454 [details] [review]:

Looks good.
Comment 4 Matthias Clasen 2012-07-15 00:47:03 UTC 
The following fix has been pushed:
760a36a Reduce amount of markup in translated messages
Comment 5 Matthias Clasen 2012-07-15 00:47:10 UTC 
Created attachment 218829 [details] [review]
Reduce amount of markup in translated messages

Markup in messages is fragile and tends to break in translations.
This patch reduces the amount of markup as far as possible.