After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679616 - Port inspector to WebKit2
Port inspector to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-07-09 10:18 UTC by Carlos Garcia Campos
Modified: 2012-08-03 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (4.02 KB, patch)
2012-07-09 10:21 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-07-09 10:18:53 UTC 
For WebKit2 we could just remove all inspector code in ephy, because the default inspector works perfectly and does mostly the same than ephy. The only thing that works differently is that ephy uses a GtkPaned when the inspector is attached. Xan and I already agreed that using a GtkPaned makes easier to resize the inspector view and it's easier to discover too. The WebKit2 inspector API is designed to allow the users to implement their own attach and rely on webkit defaults for everything else.
Comment 1 Carlos Garcia Campos 2012-07-09 10:21:48 UTC 
Created attachment 218322 [details] [review]
Patch

I've found a couple of issues in WebKit while porting the inspector. To properly work, this patch requires these two bugs fixed in webkit:

https://bugs.webkit.org/show_bug.cgi?id=90763
https://bugs.webkit.org/show_bug.cgi?id=90767
Comment 2 Xan Lopez 2012-08-02 14:10:26 UTC 
Review of attachment 218322 [details] [review]:

OK.