After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679464 - lookingGlass: Don't use a signal callback on 'paint' to draw the border
lookingGlass: Don't use a signal callback on 'paint' to draw the border
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-05 18:20 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-07-06 02:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lookingGlass: Don't use a signal callback on 'paint' to draw the border (6.00 KB, patch)
2012-07-05 18:20 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-05 18:20:49 UTC 
This is a Clutter 2.0 fix. The paint signal is going away in the future.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-05 18:20:50 UTC 
Created attachment 218116 [details] [review]
lookingGlass: Don't use a signal callback on 'paint' to draw the border

Instead, use a ClutterEffect, the proper API that has existed for since 1.0.
The 'paint' signal will go away for Clutter 2.0.
Comment 2 Colin Walters 2012-07-05 18:46:30 UTC 
Review of attachment 218116 [details] [review]:

Looks OK to me.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-07-06 02:12:31 UTC 
Attachment 218116 [details] pushed as a1837dd - lookingGlass: Don't use a signal callback on 'paint' to draw the border
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-07-06 02:13:05 UTC 
This marks the first use of gjs gobject inheritance in gnome-shell.

Gentlemen, start your debuggers.