GNOME Bugzilla – Bug 679455
Port to GStreamer 1.0
Last modified: 2012-07-24 15:22:56 UTC
Hi, at http://cgit.collabora.com/git/user/slomo/sound-juicer.git/log/?h=gst-1.0 you can find a port of sound-juicer to GStreamer 1.0 (+ some cleanups). The only regression is that the CD player feature does not set the profile on the audio-sink anymore (see http://cgit.collabora.com/git/user/slomo/sound-juicer.git/tree/src/sj-play.c?h=475dafcbedee8d6d9adf5b5b9836ad552c2198d7#n369 ) This could be solved but it's already inconsistent elsewhere too (the egg play preview thing for example). Is this necessary, should this be done everywhere too? It can also be done globally for pulseaudio by using an environment variable btw.
Sebastian, could you attach the patches here for review? (git-bz or git-bugzilla look like good helpers for that)
Created attachment 218440 [details] [review] Do initial port to GStreamer 1.0
Created attachment 218441 [details] [review] Don't set an audiosink on playbin for the preview and have a fake videosink This will make sure that the optimal audio sink is chosen and no video is played whatsoever.
Created attachment 218442 [details] [review] Use playbin for the CD playback feature
Review of attachment 218440 [details] [review]: Looks good.
Review of attachment 218441 [details] [review]: Would it make sense to disable the video decoding part of playbin through flags?
Review of attachment 218442 [details] [review]: Looks alright. ::: src/sj-play.c @@ +369,2 @@ + /* FIXME: Try this on the audiosink */ +#if 0 Remove the code instead?
(In reply to comment #6) > Review of attachment 218441 [details] [review]: > > Would it make sense to disable the video decoding part of playbin through > flags? Of course, thanks :) Will attach new patches soon (In reply to comment #7) > Review of attachment 218442 [details] [review]: > > Looks alright. > > ::: src/sj-play.c > @@ +369,2 @@ > + /* FIXME: Try this on the audiosink */ > +#if 0 > > Remove the code instead? Will do
Created attachment 218884 [details] [review] Do initial port to GStreamer 1.0
Created attachment 218885 [details] [review] Don't set an audiosink on playbin for the preview and disable video output This will make sure that the optimal audio sink is chosen and no video is played whatsoever.
Created attachment 218886 [details] [review] Use playbin for the CD playback feature
Review of attachment 218886 [details] [review]: Fine.
Review of attachment 218885 [details] [review]: Fine.
Review of attachment 218884 [details] [review]: Fine.
Thanks