After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679328 - keyboard: Plug a GSettings object leak
keyboard: Plug a GSettings object leak
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-03 13:27 UTC by Rui Matos
Modified: 2012-07-03 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Plug a GSettings object leak (746 bytes, patch)
2012-07-03 13:28 UTC, Rui Matos 		reviewed Details | Review
keyboard: Plug a GSettings object leak (3.89 KB, patch)
2012-07-03 14:24 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-07-03 13:27:59 UTC 
See patch.
Comment 1 Rui Matos 2012-07-03 13:28:01 UTC 
Created attachment 217934 [details] [review]
keyboard: Plug a GSettings object leak
Comment 2 Matthias Clasen 2012-07-03 13:45:40 UTC 
Review of attachment 217934 [details] [review]:

Do we know the life-cycle of this static settings object ? I see at least two different places where it gets created, without any concern for an already existing object...
Comment 3 Rui Matos 2012-07-03 14:18:20 UTC 
(In reply to comment #2)
> Review of attachment 217934 [details] [review]:
> 
> Do we know the life-cycle of this static settings object ? I see at least two
> different places where it gets created, without any concern for an already
> existing object...

I only see one place. Are you talking about the local variable with the same name in edit_custom_shortcut() ? That one gets unrefed properly it seems although it's slightly confusing to have it there with the same name. That function is short though...
Comment 4 Rui Matos 2012-07-03 14:24:39 UTC 
Created attachment 217937 [details] [review]
keyboard: Plug a GSettings object leak

Also, rename the variable holding it since there are other 'settings'
variables in the same file.
--

This should make it clearer.
Comment 5 Matthias Clasen 2012-07-03 14:27:03 UTC 
Review of attachment 217937 [details] [review]:

Oh, yeah. I overlooked that it was a local there.
Comment 6 Rui Matos 2012-07-03 15:06:00 UTC 
Attachment 217937 [details] pushed as 13b64e0 - keyboard: Plug a GSettings object leak