After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679097 - code review: gsd-updates-manager.c
code review: gsd-updates-manager.c
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: updates
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-29 02:15 UTC by Matthias Clasen
Modified: 2012-07-02 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthias Clasen 2012-06-29 02:15:05 UTC 
Here too all notification objects appear to be leaked.

show_offline_updates_error is leaking msg
session_inhibit is leaking retval
session_uninhibit too

in file_exists_in_root:

        if (!ret)
                goto out;
out:

that looks a bit silly
Comment 1 Richard Hughes 2012-07-02 09:42:09 UTC 
commit e2e18f39c140ac1633d9cac974561367a62a7d39
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Jul 2 10:38:58 2012 +0100

    updates: Fix a small memory leak when inhibiting the session
    
    Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=679097