GNOME Bugzilla – Bug 679005
WorkspaceSwitcherPopup: fix for dynamic workspace changes
Last modified: 2012-09-28 06:43:06 UTC
Changing the number of workspaces while the popup was visible (which happens when moving windows on the last non empty workspace) resulted in a wrong layout. Fix that, by listening to workspace-added and workspace-removed signals, and by always requesting an updated size from the actor.
Created attachment 217454 [details] [review] WorkspaceSwitcherPopup: fix for dynamic workspace changes
Review of attachment 217454 [details] [review]: why are we destroying it instead of keeping it around? ::: js/ui/windowManager.js @@ +589,3 @@ + if (direction != Meta.MotionDirection.UP && + direction != Meta.MotionDirection.DOWN) + return; separate patch @@ +596,3 @@ + newWs = this.actionMoveWindow(window, direction); + + if (!Main.overview.visible) { ??? ::: js/ui/workspaceSwitcherPopup.js @@ +125,1 @@ let primary = Main.layoutManager.primaryMonitor; Why do we have a Shell.GenericContainer here? If it's for centering, didn't we do a lot of refactoring so that CtrlAltTab/AltTab/ModalDialog all used the same code for centering too? Can't we use that?
(In reply to comment #2) > Review of attachment 217454 [details] [review]: > > why are we destroying it instead of keeping it around? Because it consumes resources and keeps two signals on global.screen, for a widget that is normally not shown. > > @@ +596,3 @@ > + newWs = this.actionMoveWindow(window, direction); > + > + if (!Main.overview.visible) { > > ??? Uh? This check existed before, as ctrl-alt-arrow can be used from the overview. > ::: js/ui/workspaceSwitcherPopup.js > @@ +125,1 @@ > let primary = Main.layoutManager.primaryMonitor; > > Why do we have a Shell.GenericContainer here? If it's for centering, didn't we > do a lot of refactoring so that CtrlAltTab/AltTab/ModalDialog all used the same > code for centering too? Can't we use that? I see no refactoring in master, each of CtrlAltTab, AltTab and ModalDialog has its own ShellGenericContainer that centers it.
Created attachment 217457 [details] [review] WindowManager: ignore ctrl-alt-left/right Fixes a regression introduced in de72065a
Review of attachment 217457 [details] [review]: Sure.
Created attachment 217458 [details] [review] Main: fix ctrl-alt-arrow in the overview Fixes a regression introduced in de72065, which changed the method names but forgot to update this code path.
Review of attachment 217458 [details] [review]: Sure.
Attachment 217457 [details] pushed as c3d3d34 - WindowManager: ignore ctrl-alt-left/right Attachment 217458 [details] pushed as 9561f77 - Main: fix ctrl-alt-arrow in the overview
*** Bug 680019 has been marked as a duplicate of this bug. ***
Review of attachment 217454 [details] [review]: Sure.
Attachment 217454 [details] pushed as f0e03b5 - WorkspaceSwitcherPopup: fix for dynamic workspace changes
*** Bug 684075 has been marked as a duplicate of this bug. ***