After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678874 - Check for kvm broken when kvm kernel module is builtin
Check for kvm broken when kvm kernel module is builtin
Status: RESOLVED INCOMPLETE
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on: 674209
Blocks:
 
 
Reported: 2012-06-26 12:30 UTC by Marc-Antoine Perennou
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marc-Antoine Perennou 2012-06-26 12:30:55 UTC
On my current box, kvm is built in the kernel and I do not have modules support.
Gnome-boxes won't start if I don't comment out the code checking for the kvm module.
Comment 1 Zeeshan Ali 2012-06-26 12:34:42 UTC
Although our checks will need to be corrected for this, this won't be a hurdle after bug#674209 is fixed.
Comment 2 Zeeshan Ali 2012-06-26 16:12:04 UTC
Updating the description and severity now that bug#674209  is fixed.
Comment 3 Christophe Fergeau 2012-06-26 16:17:29 UTC
If this means that kvm will not get used, this is really sucky and erroring out was a probably better outcome.
Comment 4 Zeeshan Ali 2012-06-26 16:18:41 UTC
(In reply to comment #3)
> If this means that kvm will not get used, this is really sucky and erroring out
> was a probably better outcome.

No, it doesn't! Unless there is a similar issue in libvirt.
Comment 5 Zeeshan Ali 2012-06-26 16:19:58 UTC
This is more about the debug output and '--checks'.
Comment 6 Marc-Andre Lureau 2012-06-26 17:02:10 UTC
(In reply to comment #5)
> This is more about the debug output and '--checks'.

Well, that's purely informative message, saying wether a KVM module is loaded. It's not like it is wrong. We should complement it to check if kvm is built in.

One quite reliable way would be to open /dev/kvm, and perhaps even check ioctl(.., KVM_GET_API_VERSION).

The other way would be to check /sys/devices/virtual/misc/kvm/dev, but perhaps some people would complain that they don't have CONFIG_SYSFS!?
Comment 7 Marc-Andre Lureau 2012-09-04 16:49:56 UTC
(In reply to comment #0)
> On my current box, kvm is built in the kernel and I do not have modules
> support.
> Gnome-boxes won't start if I don't comment out the code checking for the kvm
> module.

Although could update/augment the check for /dev/kvm,
do you have a stacktrace of what failed? What did you need to comment out? Is this still needed?

thanks
Comment 8 André Klapper 2015-01-10 12:46:24 UTC
(In reply to comment #7)
> do you have a stacktrace of what failed? What did you need to comment out? Is
> this still needed?

Hi Marc-Antoine, 
I am closing this bug report as no updated information has been provided.
Please feel free to reopen this bug if you can provide the information that was asked for in a previous comment.