After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678753 - Fails to login www.live.com
Fails to login www.live.com
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.4.x
Other All
: Normal major
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 678300 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-25 06:34 UTC by Basavaraj
Modified: 2012-07-11 00:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for https://bugzilla.gnome.org/attachment.cgi?bugid=678753 (869 bytes, patch)
2012-06-25 07:21 UTC, Basavaraj 		none Details | Review
Patch for https://bugzilla.gnome.org/attachment.cgi?bugid=678753 (920 bytes, patch)
2012-06-25 13:33 UTC, Basavaraj 		needs-work Details | Review
New Patch - live.com login failure (1.37 KB, patch)
2012-06-29 05:26 UTC, Basavaraj 		none Details | Review

Description Basavaraj 2012-06-25 06:34:40 UTC 
Fails to login www.live.com [ALWAYS]
Steps to reproduce
1. Fetch http://www.live.com
2. Enter login credentials
3. Click on signin
It redirects back to login page again, instead of profile page
Comment 1 DongJae, KIM 2012-06-25 06:40:23 UTC 
WebKit-EFL EWebLaunch browser has this problem.

Please upload your analysis.
Comment 3 Basavaraj 2012-06-25 07:30:16 UTC 
This issue is related to Cookie Parser issue.

When cookie with attribute "secure= ;" comes, cookie secure value is stored as TRUE and pointer is not moved to point semicolon (;) in function parse_one_cookie in soup-cookie.c while (*p == ';') fails. So because of this remaining cookie attributes after "secure" is not parsed. Similar issue will happen for the attribute "HttpOnly".

So solution to call parse_value (&p) for the case "secure" and "HttpOnly"

Attached the patch for reference.
Comment 4 Dan Winship 2012-06-25 12:55:23 UTC 
*** Bug 678300 has been marked as a duplicate of this bug. ***
Comment 5 Basavaraj 2012-06-25 13:33:45 UTC 
Created attachment 217197 [details] [review]
Patch for https://bugzilla.gnome.org/attachment.cgi?bugid=678753

Proper git Diff patch is attached now
Comment 6 Sergio Villar 2012-06-25 14:08:45 UTC 
Good catch! I thought both secure and HttpOnly were not expected to have any associated value, but I might be wrong...
Comment 7 Dan Winship 2012-06-25 14:46:44 UTC 
Comment on attachment 217197 [details] [review]
Patch for https://bugzilla.gnome.org/attachment.cgi?bugid=678753

This isn't quite right; look at the case for "unknown attributes" at the end; you need to only call parse_value() if has_value is TRUE, and you need to free the value it returns. (Alternately, it would be better to reorganize the code about to implement a skip_value() that doesn't do a g_strndup() in this case.)

Also, ideally, you should commit your code (with a proper commit message), and then do "git format-patch HEAD^" to create a complete commit (diff + commit message) to attach to the bug.
Comment 8 Basavaraj 2012-06-25 15:17:46 UTC 
Thanks Dan, 
Will change the patch according to your suggestion...
Comment 9 Basavaraj 2012-06-29 05:26:02 UTC 
Created attachment 217574 [details] [review]
New Patch - live.com login failure

new git diff patch attached, as per Dan comments
Comment 10 Basavaraj 2012-07-01 06:35:26 UTC 
(In reply to comment #9)
> Created an attachment (id=217574) [details] [review]
> New Patch - live.com login failure
> 
> new git diff patch attached, as per Dan comments, please review it
Comment 11 Dan Winship 2012-07-11 00:39:58 UTC 
I committed a different patch, plus a test case