After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678694 - Error when adding an indicator with no menu in the status area
Error when adding an indicator with no menu in the status area
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-24 09:11 UTC by Jean-Philippe Braun
Modified: 2012-07-10 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't break when indicator has no menu (974 bytes, patch)
2012-06-24 09:11 UTC, Jean-Philippe Braun 		committed Details | Review

Description Jean-Philippe Braun 2012-06-24 09:11:00 UTC 
Created attachment 217105 [details] [review]
Don't break when indicator has no menu

Indicators can be created with no menu by using panelMenu.Button and setting dontCreateMenu to true but when adding the indicator to the status area a TypeError is raised (menu is null).

If the indicator was added by an extension, the extension gets disabled in gsettings but remains active in the session.

Attached patch make it possible to add an indicator without menu with no issue. I think the patch can be applied on master and in the 3.4 branch
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-06-24 15:14:49 UTC 
Review of attachment 217105 [details] [review]:

Sure.
Comment 2 Florian Müllner 2012-07-10 20:22:40 UTC 
Pushed, thanks for the patch!