After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678428 - mount-operation: fix exceptions when showing password entry
mount-operation: fix exceptions when showing password entry
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-20 00:37 UTC by Cosimo Cecchi
Modified: 2012-06-20 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mount-operation: fix exceptions when showing password entry (5.73 KB, patch)
2012-06-20 00:37 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-06-20 00:37:41 UTC 
See attached patch; this is probably also a bug in 3.4.
Comment 1 Cosimo Cecchi 2012-06-20 00:37:43 UTC 
Created attachment 216767 [details] [review]
mount-operation: fix exceptions when showing password entry

This is a fallout from some changes in MessageTray.Source, which now
requires either defining the iconName/iconType properties on it, or
implementing createNotificationIcon, and we're not doing any of those.
Fix it by storing the gicon of the source object and using a helper
method to create the icon actor on demand, to avoid any case when the
same actor might be added twice to different containers.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-06-20 00:45:41 UTC 
Review of attachment 216767 [details] [review]:

I swore I tested this. Sure.
Comment 3 Cosimo Cecchi 2012-06-20 14:08:06 UTC 
Attachment 216767 [details] pushed as 281b0a3 - mount-operation: fix exceptions when showing password entry