After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678270 - Flag warning not working
Flag warning not working
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-17 20:54 UTC by Kat
Modified: 2013-11-19 02:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing "too many flags" option working (36.51 KB, image/png)
2012-07-15 02:37 UTC, Robert Ancell
  Details
Change description of overmine warning preference (1.10 KB, patch)
2013-11-19 02:52 UTC, Michael Catanzaro
committed Details | Review

Description Kat 2012-06-17 20:54:07 UTC
The preference for "Warn if too many flags (have been) placed" does not provide any warnings if too many flags have been placed on the board.

It only works if "Use "I'm not sure" flags" (blue) is enabled, in which case the extra flags are the blue type (but if one then removes some of the red flags, the extra blue ones do not revert to red automatically).

A suitable behaviour when not using the blue flags would be to either disallow placement of red flags after all of the available ones have been used up or have some sort of other marker for excess red flags that is the same for both states of the blue flag preference option.
Comment 1 Robert Ancell 2012-07-15 02:37:36 UTC
Created attachment 218840 [details]
Screenshot showing "too many flags" option working

It appears to be working for me (see attached screenshot). I have "warn if too many flags placed" enabled and "use i'm not sure flags" disabled.
Comment 2 Kat 2012-07-26 14:39:04 UTC
Sorry, problem is bad UI string! There are no warnings if too many flags are placed on the board, but it does warn if there are too many flags placed next to an open tile. I will have a think about how that can be made more clear and will improve user help to cover this.
Comment 3 Michael Catanzaro 2013-10-16 02:04:56 UTC
It's not really clear to me how to keep this string both descriptive and short.  "Warn about invalid flag placements" is the best I've come up with.  "Warn if too many flags are placed next to an uncovered tile" is a bit too long.
Comment 4 Michael Catanzaro 2013-11-19 02:52:59 UTC
Created attachment 260192 [details] [review]
Change description of overmine warning preference
Comment 5 Michael Catanzaro 2013-11-19 02:53:14 UTC
Attachment 260192 [details] pushed as 6ed230a - Change description of overmine warning preference