GNOME Bugzilla – Bug 678091
[new roster] Display favorites in the top of the roster
Last modified: 2012-06-15 11:19:36 UTC
My initial implementation doesn't support favorite contacts. Those should be displayed to the top of the roster with the most used contacts (even if I suspect they will already be there in most cases).
Created attachment 216425 [details] [review] roster-view: sort top contacts alphabetically We just want them to be on top but they should be sorted alphabetically together, not by popularity. This makes the 'top' contacts more stable.
Created attachment 216426 [details] [review] roster-view: display favorite contacts at the top of the roster as well I renamed the group to 'Top Contacts' but I'm open to a better suggestion.
Created attachment 216427 [details] [review] roster-view: display the favorite icon for the 'top' group
Review of attachment 216425 [details] [review]: ::: libempathy-gtk/empathy-roster-view.c @@ +542,1 @@ + if (top_a == top_b) This took me a second to parse. Consider a comment?
Review of attachment 216426 [details] [review]: ++
Review of attachment 216427 [details] [review]: ::: libempathy-gtk/empathy-roster-group.c @@ +97,3 @@ + + /* Icon, if any */ + if (self->priv->icon_name) Be explicit. Probably warrants a tp_str_empty() even.
Did we want to have a group for People Nearby still? They're not really part of your "contact list" per se.
(In reply to comment #4) > Review of attachment 216425 [details] [review]: > > ::: libempathy-gtk/empathy-roster-view.c > @@ +542,1 @@ > + if (top_a == top_b) > > This took me a second to parse. Consider a comment? added. (In reply to comment #6) > Review of attachment 216427 [details] [review]: > > ::: libempathy-gtk/empathy-roster-group.c > @@ +97,3 @@ > + > + /* Icon, if any */ > + if (self->priv->icon_name) > > Be explicit. Probably warrants a tp_str_empty() even. good point. done. (In reply to comment #7) > Did we want to have a group for People Nearby still? They're not really part of > your "contact list" per se. I think so, I opened bug #678156.
Attachment 216425 [details] pushed as bed1c1b - roster-view: sort top contacts alphabetically Attachment 216426 [details] pushed as a1e8643 - roster-view: display favorite contacts at the top of the roster as well Attachment 216427 [details] pushed as 094e058 - roster-view: display the favorite icon for the 'top' group