After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678076 - gst-rtsp-server unit tests
gst-rtsp-server unit tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-14 08:36 UTC by David Svensson Fors
Modified: 2012-06-20 05:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-rtsp-server unit tests (24.34 KB, patch)
2012-06-14 08:36 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2012-06-14 08:36:47 UTC 
Created attachment 216389 [details] [review]
gst-rtsp-server unit tests

The attached patch contains suggested unit tests for gst-rtsp-server. The tests set up a mount point which is mapped to one video and one audio pipeline. The different tests check RTSP DESCRIBE, SETUP and PLAY, and some error cases.

The suite passes, also with CK_FORK=no. It passes in valgrind when I've applied the patches in these Bugzilla bugs:

https://bugzilla.gnome.org/show_bug.cgi?id=678015
https://bugzilla.gnome.org/show_bug.cgi?id=678017

One natural extension could be to let tests connect to the RTP stream and receive audio and video data. Another is to test more error cases.

I added a Makefile dependency to gst-plugin-good so unit tests could load plugins from there. But I think there was already an implicit dependency, because GstRTSPMedia creates the rtpbin element.

I'm not sure if gst/rtspserver.c is the right file name. I tried to follow the naming pattern in core/base/good.
Comment 1 Wim Taymans 2012-06-19 13:26:59 UTC 
Had to do some fixes, please test:

commit df54c553ae343e69acb8b206c480ca46cbc2556b
Author: David Svensson Fors <davidsf@axis.com>
Date:   Tue Jun 19 15:25:36 2012 +0200

    rtsp: add unit test
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=678076
Comment 2 David Svensson Fors 2012-06-20 05:38:32 UTC 
Thanks! I tested it and it worked.