After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677739 - Add Escape key handler to quit selection mode
Add Escape key handler to quit selection mode
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-08 23:30 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove custom Gdk.Key bindings (1.32 KB, patch)
2012-06-08 23:30 UTC, Marc-Andre Lureau 		committed Details | Review
Use a simple select_btn ToolButton (1.59 KB, patch)
2012-06-08 23:30 UTC, Marc-Andre Lureau 		committed Details | Review
Escape key to quit selection mode (1.99 KB, patch)
2012-06-08 23:30 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-06-08 23:30:39 UTC 
Let the user quit selection mode by pressing Escape.
This is also aligned with gnome-documents behaviour.
Comment 1 Marc-Andre Lureau 2012-06-08 23:30:42 UTC 
Created attachment 216015 [details] [review]
Remove custom Gdk.Key bindings
Comment 2 Marc-Andre Lureau 2012-06-08 23:30:46 UTC 
Created attachment 216016 [details] [review]
Use a simple select_btn ToolButton
Comment 3 Marc-Andre Lureau 2012-06-08 23:30:51 UTC 
Created attachment 216017 [details] [review]
Escape key to quit selection mode
Comment 4 Zeeshan Ali 2012-06-11 17:49:38 UTC 
Review of attachment 216017 [details] [review]:

Looks good, ACK if you tested it.
Comment 5 Zeeshan Ali 2012-06-11 17:50:41 UTC 
Review of attachment 216015 [details] [review]:

ACK
Comment 6 Zeeshan Ali 2012-06-11 17:54:15 UTC 
Review of attachment 216016 [details] [review]:

ACK
Comment 7 Marc-Andre Lureau 2012-06-13 14:10:01 UTC 
Attachment 216015 [details] pushed as f31d932 - Remove custom Gdk.Key bindings
Attachment 216016 [details] pushed as 989e1f2 - Use a simple select_btn ToolButton
Attachment 216017 [details] pushed as 1167082 - Escape key to quit selection mode