In some ways, this isn't so bad. For example, you can't change VM resolution without using the VM. I think you should say what and why you would want to change VM settings. (RAM can be dynamically adjusted with ballooning afaik etc.)

I have mostly RAM and disk in mind, in therory this could all be done at runtime, in practice I assume most OSes will want to be rebooted to notice these were changed.

Created attachment 227341 [details] [review]
Add properties button to selection toolbar

This allows showing the properties view for both running and
non-running boxes.

Created attachment 227342 [details] [review]
Avoid warnings when going to properties view for non-running vm

If the vm is not running then there will be no display to
animate and show in the sidebar.

Created attachment 227343 [details] [review]
Only make force shutdown button sensitive if vm is running

This is based on the patches in bug 686777 and bug 686883

Review of attachment 227341 [details] [review]:

That easy? :)

Review of attachment 227342 [details] [review]:

ACK

::: src/machine.vala
@@ +669,3 @@
+            if (widget == null) {
+                if (previous_ui_state == UIState.WIZARD) {
+                    // FIXME: We should draw a CD instead as in the mockup:

would be nice if you could fix this fixme while you are at this.

Review of attachment 227343 [details] [review]:

ACK

Attachment 227341 [details] pushed as 9f02dc4 - Add properties button to selection toolbar
Attachment 227342 [details] pushed as 2bc6ca1 - Avoid warnings when going to properties view for non-running vm
Attachment 227343 [details] pushed as f7a74d8 - Only make force shutdown button sensitive if vm is running

Some bug though, going back to Collection will leave the selection mode, although it is still active.

Reopening to handle that.

also I am not sure if it's intentionnal,  but the selection toolbar overlay stays around when the properties page is shown.

Created attachment 227677 [details] [review]
Disable selection mode before going to properties view

We kept showing the selection bar in the properties view, and
we returned to a half-broken selection mode. Lets just disable
selection mode before going to the properties view.

Review of attachment 227677 [details] [review]:

::: src/app.vala
@@ +648,3 @@
 
+        selection_mode = false;
+

that's good enough for me if we leave selection mode, so ack

why not show the last thumbnail in properties view? it looks weird that if I go to properties via display, I get a thumbnail, if I go via collection selection, I don't get anything (running on non-running). Imho, we should have the thumbnail, if the VM is started, when clicking, it should switch to its display, if the VM is not running, it should start it and switch to display as well.

Marc: Agreed, or the CD icon as per
https://raw.github.com/gnome-design-team/gnome-mockups/master/boxes/boxes-install5.5.png
during install

Comment on attachment 227677 [details] [review]
Disable selection mode before going to properties view

Attachment 227677 [details] pushed as 361d7e4 - Disable selection mode before going to properties view

Created attachment 227720 [details] [review]
Rename MachineActor.display to MachineActor.thumbnail

This was really confusing vs Machine.display which is a SpiceDisplay
as these are defined in the same source file (but in different classes).

Created attachment 227721 [details] [review]
Machine: Always disconnect display when we're not displaying it

We used to only disconnect Machine.display when going into collection
view, but that is not always what happens. For instance, we might
go directly to the wizard if we use the "New" app menu item.
So, we move this disconnect from App.ui_state_changed to
Machine.ui_state_changed and disconnect on any state except
DISPLAY, PROPERTIES and CREDS.

Created attachment 227722 [details] [review]
Show screenshot as thumbnail in properties view if not connected

Created attachment 227723 [details] [review]
Break out machine connection into App.connect_to

This merges all the code that handles connection and going into
the CREDS state into a single function instead of being distributed
into App.select_item() and CollectionView UIState.CREDS handling.
This allows connecting to a machine without the collection view being
involved (such as when starting a box from the properties page).

It also moves the place where we collect the actor animation start
position to App.select_item() so that we can use a different start
in other cases.

Created attachment 227724 [details] [review]
Allow clicking on thumbnail in properties view

This connects to the vm.

Created attachment 227725 [details] [review]
Properties: Fix back button name

Don't use name on back button if it goes to the collection view
rather than to the named display.

Created attachment 227726 [details] [review]
Show cd icon, not thumbnail in properties during install

Also, don't allow clicking on it to connect to the vm.

The image is squashed a bit, need to figure out how to keep
the aspect ratio of it.

Review of attachment 227726 [details] [review]:

The series looks good. The only bug I noticed is that wizard-properties with remote display will still let you click the thumbnail.

Attachment 227720 [details] pushed as 2f9ea2b - Rename MachineActor.display to MachineActor.thumbnail
Attachment 227721 [details] pushed as 9bfb280 - Machine: Always disconnect display when we're not displaying it
Attachment 227722 [details] pushed as dd208c6 - Show screenshot as thumbnail in properties view if not connected
Attachment 227723 [details] pushed as ec26d54 - Break out machine connection into App.connect_to
Attachment 227724 [details] pushed as bb5ee04 - Allow clicking on thumbnail in properties view
Attachment 227725 [details] pushed as 4dfa749 - Properties: Fix back button name
Attachment 227726 [details] pushed as 02a1c08 - Show cd icon, not thumbnail in properties during install

Remaining issues:
* squashed CD icon
* wizard-properties with remote display will let you click the thumbnail.

Remaining issues split out to bug 688329 and 688328. Closing this.