GNOME Bugzilla – Bug 677633
Cannot delete favourite
Last modified: 2012-12-28 14:00:57 UTC
I have a contact marked as favourite since long ago, but I don't want it to be there anymore. I push right button -> Edit and uncheck Favourite. After closing the window, nothing happened. If i open it again, it remains checked.
I think I'm having a similar problem, but don't know if it should be placed here... I'm trying to delete a contact from windows live: his account has been hijacked and he's now spamming. However, every time I try to delete the contact, he just stays there. What can I do?
I also see this, with empathy 3.2.2 on Fedora 16. When I try to remove a particular favourite, I see the following on the terminal: (empathy:10332): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed Note that I can add and remove other favourites without issue.
I can reproduce this issue. - Edit a Telepathy contact (not a meta contact) - Mark it as favorite and close the edit dialog - re-open it: the checkbox is unchecked - Restart empathy - Now the contact is marked as favorite. That seems to be a problem in Folks : tpf-logger.vala: The callback of this signal is only fired once Logger._logger.favourite_contacts_changed.connect once it should be fired for each tpf store. So, as 'ap' is different from 'this._account_path' the signal is ignored.
(In reply to comment #2) > I also see this, with empathy 3.2.2 on Fedora 16. When I try to remove a > particular favourite, I see the following on the terminal: > > (empathy:10332): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed > > Note that I can add and remove other favourites without issue. This sounds like a different issue. Can you please try with a more recent version and open another bug if needed?
Thanks to Guillaume for debugging this one very thoroughly and suggesting the fix. commit ce55fa2bf2f5f8cf95532da585d835bafeeb3347 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Fri Dec 28 13:47:50 2012 +0000 telepathy: Yield subsequent Logger.prepare() calls if one is pending If one PersonaStore began to prepare its Logger, then yielded on a D-Bus call, another PersonaStore could begin to prepare its Logger and also try to create a static D-Bus proxy (which is only supposed to be created once). This is because the original async call hasn’t returned and set Logger._logger by that point. Fix this by keeping a queue of pending prepare() calls which is signalled by the initial prepare() call once it finishes yielding. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=677633 NEWS | 1 + backends/telepathy/lib/tpf-logger.vala | 47 +++++++++++++++++++++++++++++++++++++++++------ 2 files changed, 42 insertions(+), 6 deletions(-)