After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677605 - "Too many open files" when loading thumbnail images
"Too many open files" when loading thumbnail images
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-07 07:29 UTC by Daiki Ueno
Modified: 2012-06-11 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.16 KB, patch)
2012-06-07 07:29 UTC, Daiki Ueno 		none Details | Review

Description Daiki Ueno 2012-06-07 07:29:18 UTC 
Created attachment 215822 [details] [review]
patch

I just tried the new gnome-font-viewer in jhbuild.  It launched ok on the first time, but from the second time, it fails to start with:

** (gnome-font-viewer:8050): WARNING **: Can't get font name: Error opening file: Too many open files

From the strace output, it actually tries to open > 1024 fd's at once when loading thumbnail images (almost all font packages in Fedora are installed here).

I guess thread yielding is required when opening so many files with g_file_read_async.
Comment 1 Cosimo Cecchi 2012-06-11 20:38:31 UTC 
Thanks for the report; I now refactored the thumbnailing code around g_io_scheduler_push_job(), which also makes it more robust, and fixes this bug.