After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677441 - no previous prototype for ‘_shell_link_to_shell_js’
no previous prototype for ‘_shell_link_to_shell_js’
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-05 07:37 UTC by Guillaume Desmottes
Modified: 2012-06-06 08:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing _shell_link_to_shell_js() declaration (686 bytes, patch)
2012-06-05 07:38 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-06-05 07:37:44 UTC 
I got this when trying to build the 3.4 branch of the Shell:


gcc -DHAVE_CONFIG_H -I. -I..  -pthread -DMUTTER_MAJOR_VERSION=3 -DMUTTER_MINOR_VERSION=4 -DMUTTER_MICRO_VERSION=1 -DMUTTER_PLUGIN_API_VERSION=3 -D_REENTRANT -I/home/cassidy/usr/include/gio-unix-2.0/ -I/home/cassidy/usr/include/glib-2.0 -I/home/cassidy/usr/lib64/glib-2.0/include -I/home/cassidy/usr/include/gtk-3.0 -I/home/cassidy/usr/include/telepathy-1.0 -I/home/cassidy/usr/include/gnome-menus-3.0 -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng15 -I/usr/include/gee-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/mutter -I/usr/include/clutter-1.0 -I/usr/include/cogl -I/usr/include/json-glib-1.0 -I/usr/include/libdrm -I/usr/include/gjs-1.0 -I/usr/include/gobject-introspection-1.0 -I/usr/include/js -I/usr/lib64/libffi-3.0.10/include -I/usr/include/nspr4 -I/usr/include/gstreamer-0.10 -I/usr/include/libsoup-2.4 -I/usr/include/startup-notification-1.0 -I/usr/include/telepathy-logger-0.2 -I/usr/include/polkit-1 -I/usr/include/libnm-glib -I/usr/include/NetworkManager -I/usr/include/gnome-keyring-1 -I/usr/include/gcr-3 -I/usr/include/gck-1 -I/usr/include/p11-kit-1 -I/usr/include/gsettings-desktop-schemas    -I./tray -DVERSION=\"3.4.1\" -DLOCALEDIR=\"/home/cassidy/usr/share/locale\" -DDATADIR=\"/home/cassidy/usr/share\" -DGNOME_SHELL_LIBEXECDIR=\"/home/cassidy/usr/libexec\" -DGNOME_SHELL_DATADIR=\"/home/cassidy/usr/share/gnome-shell\" -DGNOME_SHELL_PKGLIBDIR=\"/home/cassidy/usr/lib64/gnome-shell\" -DJSDIR=\"/home/cassidy/usr/share/gnome-shell/js\"   -g -Wall -Wmissing-prototypes -Werror -Wno-error=deprecated-declarations -MT gnome_shell_real-main.o -MD -MP -MF .deps/gnome_shell_real-main.Tpo -c -o gnome_shell_real-main.o `test -f 'main.c' || echo './'`main.c
main.c:355:1: erreur: no previous prototype for ‘_shell_link_to_shell_js’ [-Werror=missing-prototypes]
cc1: all warnings being treated as errors
Comment 1 Guillaume Desmottes 2012-06-05 07:38:40 UTC 
Created attachment 215614 [details] [review]
add missing _shell_link_to_shell_js() declaration

Fix missing-prototypes warning.
Comment 2 Florian Müllner 2012-06-05 13:25:55 UTC 
... or just cherry-pick the patch in bug 676347 (though I'm not aware of any plans for another 3.4.x release, so not sure how useful that'd really be)
Comment 3 Colin Walters 2012-06-05 13:31:10 UTC 
Review of attachment 215614 [details] [review]:

This only needs applying to gnome-3-4, it's fixed on master.
Comment 4 Guillaume Desmottes 2012-06-06 08:14:37 UTC 
Pushed to 3.4, thanks.

Attachment 215614 [details] pushed as 98c3f6b - add missing _shell_link_to_shell_js() declaration