After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677283 - box-layout: Honor actor expand and alignment
box-layout: Honor actor expand and alignment
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-01 14:59 UTC by Bastian Winkler
Modified: 2012-06-04 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
box-layout: Honor actor expand and alignment (3.97 KB, patch)
2012-06-01 14:59 UTC, Bastian Winkler 		committed Details | Review
examples: Updated box-layout example (18.75 KB, patch)
2012-06-02 13:03 UTC, Bastian Winkler 		none Details | Review
examples: Updated box-layout example (19.16 KB, patch)
2012-06-02 13:16 UTC, Bastian Winkler 		committed Details | Review
box-layout: Deprecate expand/fill/align child properties (7.75 KB, patch)
2012-06-04 10:43 UTC, Bastian Winkler 		committed Details | Review

Description Bastian Winkler 2012-06-01 14:59:46 UTC 
Check if the actor has needs to expand and use Actor.allocate() instead
of Actor.allocate_align_fill() in that case.
Comment 1 Bastian Winkler 2012-06-01 14:59:49 UTC 
Created attachment 215429 [details] [review]
box-layout: Honor actor expand and alignment
Comment 2 Bastian Winkler 2012-06-02 13:03:22 UTC 
Created attachment 215488 [details] [review]
examples: Updated box-layout example

Updated test-box-layout to use modern API and move it to examples.
Comment 3 Bastian Winkler 2012-06-02 13:16:32 UTC 
Created attachment 215489 [details] [review]
examples: Updated box-layout example

Updated test-box-layout to use modern API and move it to examples.
Comment 4 Bastian Winkler 2012-06-04 10:43:56 UTC 
Created attachment 215535 [details] [review]
box-layout: Deprecate expand/fill/align child properties

These are covered by ClutterActor:[xy]-align and
ClutterActor:[xy]-expand
Comment 5 Emmanuele Bassi (:ebassi) 2012-06-04 11:41:55 UTC 
Review of attachment 215429 [details] [review]:

looks good; at some point we'll have to figure out how to let the BoxLayout layout properties influence the needs_expand() computations.
Comment 6 Emmanuele Bassi (:ebassi) 2012-06-04 11:42:12 UTC 
Review of attachment 215489 [details] [review]:

looks okay
Comment 7 Emmanuele Bassi (:ebassi) 2012-06-04 11:42:29 UTC 
Review of attachment 215535 [details] [review]:

looks okay
Comment 8 Bastian Winkler 2012-06-04 14:17:35 UTC 
Attachment 215429 [details] pushed as 157353e - box-layout: Honor actor expand and alignment
Attachment 215489 [details] pushed as f14c71c - examples: Updated box-layout example
Attachment 215535 [details] pushed as c7c3d85 - box-layout: Deprecate expand/fill/align child properties