After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677101 - VM view state lost on VM reboot
VM view state lost on VM reboot
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-30 14:43 UTC by Christophe Fergeau
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stay on Display during wizard reboot (8.47 KB, patch)
2012-06-11 10:27 UTC, Marc-Andre Lureau
committed Details | Review

Description Christophe Fergeau 2012-05-30 14:43:21 UTC
- start a Windows XP unattended install (probably works with other OSes)
- click on the VM icon to get its display maximized
- wait until Windows installer reboots

Result:
- the VM display is back to iconized

Expected result:
- VM is still maximized
Comment 1 Marc-Andre Lureau 2012-06-08 23:49:52 UTC
During vm-creator time, the machine is shutdown, and restarted with post_install_setup (). A shutdown will lead to a display disconnect, which will trigger a UI switch back to collection view. We need a special case when the machine is first shutdown during unattended installation. It also need to handle the case where the shutdown is caused by installation failure.
Comment 2 Marc-Andre Lureau 2012-06-09 00:02:34 UTC
assigning to me, as I started a bit on that
Comment 3 Zeeshan Ali 2012-06-09 15:28:32 UTC
(In reply to comment #1)
> During vm-creator time, the machine is shutdown, and restarted with
> post_install_setup (). A shutdown will lead to a display disconnect, which will
> trigger a UI switch back to collection view. We need a special case when the
> machine is first shutdown during unattended installation. It also need to
> handle the case where the shutdown is caused by installation failure.

Right. Keep some things in mind though:

1. Solution doesnt need to be limited to unattended installs.
2. We have custom XML in domain config that tells if installation is in progress.
3. Wonder how to deal with OSs that reboot multiple times during installations, e.g windows.
Comment 4 Christophe Fergeau 2012-06-09 15:47:05 UTC
(In reply to comment #1)
> During vm-creator time, the machine is shutdown, and restarted with
> post_install_setup ()

Why is that? Shouldn't/couldn't it be reset instead?
Comment 5 Zeeshan Ali 2012-06-09 20:28:42 UTC
(In reply to comment #4)
> (In reply to comment #1)
> > During vm-creator time, the machine is shutdown, and restarted with
> > post_install_setup ()
> 
> Why is that? Shouldn't/couldn't it be reset instead?

We need to change the configuration after first boot so we ask libvirt to shutdown on reset for first boot.
Comment 6 Marc-Andre Lureau 2012-06-11 10:27:50 UTC
Created attachment 216094 [details] [review]
Stay on Display during wizard reboot

During unattended installation, the VM may be rebooted.
Comment 7 Marc-Andre Lureau 2012-06-11 10:28:37 UTC
note: the patch is wip and not tested thoroughly.
Comment 8 Zeeshan Ali 2012-07-31 00:38:06 UTC
I didn't review this patch because you said in the latest commit that patch is WIP and not tested thoroughly so I was waiting on you to provide an improved version or inform me if its good in your opinion.
Comment 9 Marc-Andre Lureau 2012-07-31 10:26:13 UTC
(In reply to comment #8)
> I didn't review this patch because you said in the latest commit that patch is
> WIP and not tested thoroughly so I was waiting on you to provide an improved
> version or inform me if its good in your opinion.

That patch  is part of 
https://bugzilla.gnome.org/show_bug.cgi?id=680293, and has been reviewed.
Comment 10 Christophe Fergeau 2012-09-12 08:33:10 UTC
I think this is mostly fixed by now.