GNOME Bugzilla – Bug 677034
wizard state is not fully reset when going back to the first screen
Last modified: 2016-03-31 13:57:58 UTC
Start new VM creation Click next Choose 'enter URL' Click on the 'back' button in the top bar (not the arrow left of 'Enter URL') Click next Result: the "Enter URL" screen is shown Expected Result: the screen to select the source (URL, iso from disk, ...) is shown I thought I had already filed this bug but couldn't find it even though I searched for it.
Created attachment 216007 [details] [review] Do not show URL entry when going back after selecting source Show the same source list when going back, the item previously selected will have the focus again.
Created attachment 216008 [details] [review] Always reset wizard source page Always show the SourcePage.MAIN when switching to wizard SOURCE page.
Review of attachment 216007 [details] [review]: > Show the same source list when going back, the item previously > selected will have the focus again. Sure but only if item was selected from the menu, not from 'URL' or 'File'. The current behavior was actually a fix in the times when when didn't have ready medias in the menu.
Created attachment 216280 [details] [review] Do not show URL entry when going back after selecting source Show the same source list when going back, the item previously selected will have the focus again.
Created attachment 216281 [details] [review] Always reset wizard source page when moving forward Always show the SourcePage.MAIN when switching to wizard SOURCE page from INTRODUCTION.
Review of attachment 216281 [details] [review]: ACK
first patch is ack too?
Review of attachment 216280 [details] [review]: Looks good otherwise. ::: src/wizard.vala @@ -104,3 +104,3 @@ } - public Wizard () { + private void wizard_source_update_next () { coding-style: private functions after public ones.. @@ -106,7 +106,7 @@ - public Wizard () { - vm_creator = new VMCreator (); - wizard_source = new Boxes.WizardSource (media_manager); ... 4 more ... + private void wizard_source_update_next () { + next_button.sensitive = false; + ... 4 more ... shorter & more consistent w/ what we do below: next_button.sensitive = wizard_source.selected != null;
Review of attachment 216280 [details] [review]: ::: src/wizard.vala @@ -104,3 +104,3 @@ } - public Wizard () { + private void wizard_source_update_next () { I don't see the problem. @@ -106,7 +106,7 @@ - public Wizard () { - vm_creator = new VMCreator (); - wizard_source = new Boxes.WizardSource (media_manager); ... 4 more ... + private void wizard_source_update_next () { + next_button.sensitive = false; + ... 4 more ... ok
Attachment 216280 [details] pushed as 5baba3e - Do not show URL entry when going back after selecting source Attachment 216281 [details] pushed as 376af92 - Always reset wizard source page when moving forward