After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676823 - test-ui: We only really support GTK+ 3.x builds
test-ui: We only really support GTK+ 3.x builds
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-25 14:42 UTC by Bastien Nocera
Modified: 2012-05-25 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test-ui: We only really support GTK+ 3.x builds (951 bytes, patch)
2012-05-25 14:42 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2012-05-25 14:42:40 UTC
.
Comment 1 Bastien Nocera 2012-05-25 14:42:41 UTC
Created attachment 214945 [details] [review]
test-ui: We only really support GTK+ 3.x builds

So stop fooling ourselves, that code just doesn't work with GTK+ 2.x
Comment 2 Bastien Nocera 2012-05-25 14:43:19 UTC
gcc -DHAVE_CONFIG_H -I. -I../../src -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2     -DPREFIX=/usr -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm    -I../../src -I../../src/data -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -Wmissing-declarations -std=c99  -c -o grilo_test_ui_0.1-main.o `test -f 'main.c' || echo './'`main.c
gcc -DHAVE_CONFIG_H -I. -I../../src -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2     -DPREFIX=/usr -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm    -I../../src -I../../src/data -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -Wmissing-declarations -std=c99  -c -o grilo_test_ui_0.1-flickr-auth.o `test -f 'flickr-auth.c' || echo './'`flickr-auth.c
main.c: In function 'store_btn_clicked_cb':
main.c:975:3: warning: implicit declaration of function 'gtk_box_new' [-Wimplicit-function-declaration]
main.c:975:3: warning: nested extern declaration of 'gtk_box_new' [-Wnested-externs]
main.c:975:20: warning: initialization makes pointer from integer without a cast [enabled by default]
main.c:982:7: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c:989:7: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c: In function 'ui_setup':
main.c:1587:24: warning: initialization makes pointer from integer without a cast [enabled by default]
main.c:1594:3: warning: implicit declaration of function 'gtk_paned_new' [-Wimplicit-function-declaration]
main.c:1594:3: warning: nested extern declaration of 'gtk_paned_new' [-Wnested-externs]
main.c:1594:20: warning: initialization makes pointer from integer without a cast [enabled by default]
main.c:1595:15: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c:1596:15: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c:1602:21: warning: initialization makes pointer from integer without a cast [enabled by default]
main.c:1603:21: warning: initialization makes pointer from integer without a cast [enabled by default]
main.c:1610:8: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c:1630:8: warning: assignment makes pointer from integer without a cast [enabled by default]
main.c:1650:7: warning: assignment makes pointer from integer without a cast [enabled by default]
/bin/sh ../../libtool  --tag=CC   --mode=link gcc -DPREFIX=/usr -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm    -I../../src -I../../src/data -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -Wmissing-declarations -std=c99   -Wl,-z,relro  -o grilo-test-ui-0.1 grilo_test_ui_0.1-main.o grilo_test_ui_0.1-flickr-auth.o -Wl,--export-dynamic -pthread -lgmodule-2.0 -lrt -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lxml2   -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lglib-2.0    ../../src/libgrilo-0.1.la 
libtool: link: gcc -DPREFIX=/usr -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm -I../../src -I../../src/data -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Wmissing-declarations -std=c99 -Wl,-z -Wl,relro -o .libs/grilo-test-ui-0.1 grilo_test_ui_0.1-main.o grilo_test_ui_0.1-flickr-auth.o -Wl,--export-dynamic -pthread  -lgmodule-2.0 -lrt -lxml2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lglib-2.0 ../../src/.libs/libgrilo-0.1.so -pthread
grilo_test_ui_0.1-main.o: In function `store_btn_clicked_cb':
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:975: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:982: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:989: undefined reference to `gtk_box_new'
grilo_test_ui_0.1-main.o: In function `ui_setup':
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1587: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1594: undefined reference to `gtk_paned_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1595: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1596: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1602: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1603: undefined reference to `gtk_box_new'
/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1610: undefined reference to `gtk_box_new'
grilo_test_ui_0.1-main.o:/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui/main.c:1630: more undefined references to `gtk_box_new' follow
collect2: error: ld returned 1 exit status
make[2]: *** [grilo-test-ui-0.1] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/grilo-0.1.19/tools/grilo-test-ui'
make[1]: Leaving directory `/builddir/build/BUILD/grilo-0.1.19/tools'
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
Comment 3 Juan A. Suarez Romero 2012-05-25 15:01:15 UTC
commit 9a1a2f0856b353fbf94ead22b4a31f2ee3a4d0b0
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri May 25 15:40:18 2012 +0100

    test-ui: We only really support GTK+ 3.x builds
    
    So stop fooling ourselves, that code just doesn't work with GTK+ 2.x
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676823

 configure.ac |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)