After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676743 - ginputstream: Fix up annotations for g_input_stream_read{,_all}
ginputstream: Fix up annotations for g_input_stream_read{,_all}
Status: RESOLVED DUPLICATE of bug 671139
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-05-24 14:16 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-05-24 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ginputstream: Fix up annotations for g_input_stream_read{,_all} (1.89 KB, patch)
2012-05-24 14:16 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-05-24 14:16:18 UTC 
See patch. Quick introspection fix.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-24 14:16:20 UTC 
Created attachment 214868 [details] [review]
ginputstream: Fix up annotations for g_input_stream_read{,_all}
Comment 2 Colin Walters 2012-05-24 14:23:41 UTC 
Review of attachment 214868 [details] [review]:

I don't think that actually works; did you test this?

Bindings are going to assume we return a newly-allocated buffer, they have to free with g_free(), but that's not the case here.  It's more like (out caller-allocates), but the problem there is that then @count isn't (out).  

See https://bugzilla.gnome.org/show_bug.cgi?id=671139
Comment 3 Dan Winship 2012-05-24 14:25:14 UTC 
> but the problem there is that then @count isn't (out).

@count isn't (out) either way
Comment 4 Colin Walters 2012-05-24 14:34:16 UTC 

*** This bug has been marked as a duplicate of bug 671139 ***