After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676676 - Do not skip review page for unknown media
Do not skip review page for unknown media
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
: 672532 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-05-23 17:37 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not skip review page for unknown media (5.50 KB, patch)
2012-05-23 17:37 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-05-23 17:37:33 UTC 
Currently, Boxes boot an unknown media directly
without any review or confirmation.
Although this is a nice feature when running a
live iso automatically, it feels quite surprising
when going through the wizard manually.

Add back confirmation/review step, and skip
correctly pages when moving around.
Comment 1 Marc-Andre Lureau 2012-05-23 17:37:37 UTC 
Created attachment 214802 [details] [review]
Do not skip review page for unknown media
Comment 2 Zeeshan Ali 2012-05-23 18:47:13 UTC 
Review of attachment 214802 [details] [review]:

ACK
Comment 3 Marc-Andre Lureau 2012-05-23 23:08:48 UTC 
Attachment 214802 [details] pushed as 83f3a69 - Do not skip review page for unknown media
Comment 4 Christophe Fergeau 2012-05-24 09:17:10 UTC 
This also skips it for live medias. I prefer things this way, but I'm not sure this was intentional
Comment 5 Marc-Andre Lureau 2012-05-24 11:23:49 UTC 
yeah, I should have said all media in fact.

The point is that after selecting an iso from the wizard manually, we shouldn't run it immediately, ever, but ask for confirmation. That should allow us to provide a minimum of tweaking in the future too.
Comment 6 Christophe Fergeau 2012-05-29 14:00:58 UTC 
*** Bug 672532 has been marked as a duplicate of this bug. ***