After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676624 - gsttypefindhelper has proto mismatch
gsttypefindhelper has proto mismatch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other All
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-23 08:16 UTC by Brian Cameron
Modified: 2012-05-24 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue. (503 bytes, patch)
2012-05-23 08:16 UTC, Brian Cameron 		none Details | Review

Description Brian Cameron 2012-05-23 08:16:39 UTC 
Created attachment 214734 [details] [review]
patch fixing issue.

The proto for helper_find_suggest has a different argument than the actual function in the same file has.  This causes the Sun Studio comnpiler to fail.
The attached patch fixes this compile issue.
Comment 1 Sebastian Dröge (slomo) 2012-05-23 08:48:04 UTC 
Could you attach this in "git format-patch" format?
Comment 2 Brian Cameron 2012-05-23 08:52:13 UTC 
Actually this would be a bother for me.  I was just providing some patches that we put in our build system upstream.

Normally we do not do not generate patches within git source trees.  Since our
build system uses tarballs, the Desktop team at Solaris has always just been
generating patches via this command:

gpatch -urp file.old file.new > patch.diff

Is there some other way I can attach the bug in a format you like, such as different gpatch arguments or using ".txt" as the extension instead of diff?
If different gpatch arguments would work, I can work with people here at Oracle
to use what is recommended.
Comment 3 Wim Taymans 2012-05-24 09:05:44 UTC 
commit 30c6d0cc35aa76893d9c55a9525ddfd3a6754bca
Author: Brian Cameron <brian.cameron at oracle.com>
Date:   Thu May 24 11:02:53 2012 +0200

    typefind: fix prototype of helper_find_suggest
    
    The proto for helper_find_suggest has a different argument than the actual
    function in the same file has.  This causes the Sun Studio compiler to fail.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=676624