GNOME Bugzilla – Bug 676531
Make nautilus a bit more GNOME 3 style
Last modified: 2014-12-30 21:18:39 UTC
Created attachment 214626 [details] current screenshot The search interface doesn't quite fit our GNOME 3 search patterns. I think we can improve it.
Created attachment 217654 [details] [review] Remove text besides icons mode for icon view This doesn't really work well, it is inconsistent with the file chooser, isn't use anywhere else in GNOME, and we want to enhance the list view to cover this case.
Created attachment 217655 [details] [review] Use a list model instead of a tree model It is the list view after all. Tree models don't work well on touch and it isn't consistent with the file chooser.
Created attachment 217656 [details] [review] Use a more GNOME 3 toolbar layout
Created attachment 217657 [details] [review] Migrate menu bar to a view menu button
Created attachment 217658 [details] [review] Don't show a titlebar when maximized
Review of attachment 217654 [details] [review]: Looks good.
Review of attachment 217657 [details] [review]: ::: src/nautilus-actions.h @@ +49,3 @@ #define NAUTILUS_ACTION_CLOSE_ALL_WINDOWS "Close All Windows" #define NAUTILUS_ACTION_SEARCH "Search" +#define NAUTILUS_ACTION_VIEW_MENU "View Menu" This doesn't seem to be used or defined anywhere ::: src/nautilus-toolbar.c @@ +188,3 @@ + menu = gtk_ui_manager_get_widget (self->priv->ui_manager, "/ViewMenu"); + gtk_menu_button_set_menu (GTK_MENU_BUTTON (tool_button), menu); + I don't think it's necessary to name this button ::: src/nautilus-window-menus.c @@ +767,2 @@ + action = GTK_ACTION + (gtk_toggle_action_new (NAUTILUS_ACTION_SEARCH, This seems to be a copy/paste leftover because the search action is constructed already a few lines above. @@ -916,2 @@ nautilus_window_initialize_trash_icon_monitor (window); - nautilus_window_initialize_go_menu (window); Can we remove this function completely then?
Review of attachment 217655 [details] [review]: Looks good
Review of attachment 217656 [details] [review]: Looks good
Review of attachment 217658 [details] [review]: Looks good, after we removed the menubar
Still to do: * There is still some broken stuff in the menu move. The Edit menu doesn't move over at all. And the initialization is split between window and toolbar. * Need to figure out the theme rendering errors in the pathbar * The toolbar buttons for back/forward and search need to be square
Created attachment 217843 [details] [review] Remove the Go menu
Created attachment 217844 [details] [review] Migrate menu bar to a view menu button
Created attachment 217845 [details] [review] Don't show a titlebar when maximized
Created attachment 217850 [details] [review] Migrate menu bar to a view menu button Fix typo in view mode shortlist and add back location bar until we can integrate it with search.
Review of attachment 217845 [details] [review]: Looks good
Review of attachment 217850 [details] [review]: Looks mostly good...some comments below. ::: src/nautilus-shell-ui.xml @@ -86,3 @@ - <menuitem action="NautilusHelpShare"/> - <separator/> - <placeholder name="Extension Actions"/> There's code in nautilus-window-menus.c that makes these entries only visible when the environment doesn't support displaying an application menu...we should probably keep them in the gear menu in that case. ::: src/nautilus-toolbar.c @@ +189,3 @@ + gtk_menu_button_set_menu (GTK_MENU_BUTTON (tool_button), menu); + image = gtk_image_new (); + /* Page Menu */ Why using a different icon size for this? @@ +249,3 @@ switch (property_id) { + case PROP_UI_MANAGER: + self->priv->ui_manager = g_value_dup_object (value); You should either use get_object() here or unref this in the toolbar's finalize. It's probably fine to use get_object() since the toolbar wouldn't outlive the window that creates it. ::: src/nautilus-window.c @@ -1240,3 @@ nautilus_window_initialize_actions (window); - menu = gtk_ui_manager_get_widget (window->details->ui_manager, "/MenuBar"); Don't we need to also remove the menu variable here?
Review of attachment 217843 [details] [review]: Okay, but I think it's cleaner to move the Go To Location action here in this patch rather than removing it and re-adding it in the gear menu one.
Attachment 217843 [details] pushed as 2c3191c - Remove the Go menu Attachment 217845 [details] pushed as 3c3d278 - Don't show a titlebar when maximized Attachment 217850 [details] pushed as faf6465 - Migrate menu bar to a view menu button
(In reply to comment #2) > Use a list model instead of a tree model > > It is the list view after all. Tree models don't work well on > touch and it isn't consistent with the file chooser. Please do not remove the tree model! It is an important feature that helps browsing through deeply nested directory structures. If it does not work well on touch devices, make it at least configurable for the people still using Gnome the traditional way (mouse).
> Please do not remove the tree model! It is an important feature that helps > browsing through deeply nested directory structures. I second that. it's the reason I kept using nautilus. It can be very useful. It makes it possible to show different hierarchy levels on the same window. On some file hierarchies, it is just necessary. Perhaps there is something else to replace the tree view, but until then I'd suggest it is kept as it is.
> Tree models don't work well on touch Why is this an appropriate ground on which to *remove* the tree view? Some of us still have a mouse. If you want to know why it's a bad idea to completely remove features which "don't work on touch", I suggest you install the Windows 8 preview.
Such contraversial decisions should always be left with user-customisable option. For me the left tree is invaluable, because it is independently scrollable from the right pane, and so allows you to drag/drop between folders, and switch view between folders. Why anyone would think they could remove such an important and well-used feature and not provide the option to turn it back on, is beyond my comprehension. Complete failure.
(In reply to comment #2) > Created an attachment (id=217655) [details] [review] > Use a list model instead of a tree model > > It is the list view after all. Tree models don't work well on > touch and it isn't consistent with the file chooser. I cannot understand why you would remove such an important feature without the option to revert it. There is NO WAY that the list view can replace the left-hand tree view panel. It's a completely different concept. The left tree panel is incredibly useful to a large number of people. You are alienating everyone who uses a mouse in favour of touch users. What proportion of your users are mouse, and what proportion are touch???
A bit late, but I too agree that the option to continue to use a tree view in the sidebar pane should be permitted via an option. If you want to set that to flat view by default, that's fine in an environment where touch interface is bing used, but it is irrational to simply remove a feature that may not be appropriate in one of many use cases.