After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676500 - Errors when building with warnings treated as errors
Errors when building with warnings treated as errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-21 13:49 UTC by David Svensson Fors
Modified: 2012-05-22 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes for compiler warnings (3.43 KB, patch)
2012-05-21 13:49 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2012-05-21 13:49:00 UTC 
Created attachment 214564 [details] [review]
Fixes for compiler warnings

We build gst-rtsp-server with warnings treated as errors, and get some compilation errors that we think should be corrected in the code. The errors, which are fixed by the proposed patch that has been attached below, are the following:

gst-rtsp-server/gst/rtsp-server/rtsp-auth.c: In function 'gst_rtsp_auth_get_property':
gst-rtsp-server/gst/rtsp-server/rtsp-auth.c:90: error: unused variable 'auth'
gst-rtsp-server/gst/rtsp-server/rtsp-auth.c: In function 'gst_rtsp_auth_set_property':
gst-rtsp-server/gst/rtsp-server/rtsp-auth.c:102: error: unused variable 'auth'

gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c: In function 'payloader_filter':
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c:124: error: unused variable 'res'
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c: In function 'find_payloader':
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c:293: error: unused variable 'tmp'
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c: In function 'autoplug_continue_cb':
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c:343: error: unused variable 'res'
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c:340: error: unused variable 'tmp'
gst-rtsp-server/gst/rtsp-server/rtsp-media-factory-uri.c:340: error: unused variable 'list'

gst-rtsp-server/gst/rtsp-server/rtsp-client.c:429: error: 'do_send_data_list' defined but not used

gst-rtsp-server/gst/rtsp-server/rtsp-server.c: In function 'gst_rtsp_server_io_func':
gst-rtsp-server/gst/rtsp-server/rtsp-server.c:796: error: 'result' may be used uninitialized in this function
gst-rtsp-server/gst/rtsp-server/rtsp-server.c: In function 'gst_rtsp_server_create_socket':
gst-rtsp-server/gst/rtsp-server/rtsp-server.c:565: error: 'socket' may be used uninitialized in this function
Comment 1 Wim Taymans 2012-05-22 13:40:34 UTC 
commit ffa3166fbd4ae475047a746bf8e477cc5c4d32c2
Author: David Svensson Fors <davidsf at axis.com>
Date:   Tue May 22 15:37:25 2012 +0200

    rtsp: fix compiler warnings
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=676500