After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676356 - icon-theme: Allow symbolic GFileIcons
icon-theme: Allow symbolic GFileIcons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-19 05:16 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-06-01 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon-theme: Allow symbolic GFileIcons (1.09 KB, patch)
2012-05-19 05:16 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
icon-theme: Allow symbolic GFileIcons (1.18 KB, patch)
2012-06-01 08:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-05-19 05:16:39 UTC 
See https://mail.gnome.org/archives/gnome-shell-list/2012-May/msg00116.html
for details here.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-19 05:16:41 UTC 
Created attachment 214434 [details] [review]
icon-theme: Allow symbolic GFileIcons

gtk_icon_info_load_symbolic checks for the existance of a filename parameter
so it can include it along with the stylesheet. We don't set the filename
parameter when creating the info for a GFileIcon, for some reason.
Comment 2 Cosimo Cecchi 2012-05-31 03:33:14 UTC 
Review of attachment 214434 [details] [review]:

::: gtk/gtkicontheme.c
@@ +3864,3 @@
 
+      if (G_IS_FILE_ICON (icon))
+        info->filename = g_file_get_path (g_file_icon_get_file (G_FILE_ICON (icon)));

You should check for the return value of g_file_icon_get_file() to be non-NULL before passing it to g_file_get_path().
Other than this, looks good to me.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-01 08:10:38 UTC 
Created attachment 215394 [details] [review]
icon-theme: Allow symbolic GFileIcons

gtk_icon_info_load_symbolic checks for the existance of a filename parameter
so it can include it along with the stylesheet. We don't set the filename
parameter when creating the info for a GFileIcon, for some reason.
Comment 4 Cosimo Cecchi 2012-06-01 13:06:31 UTC 
Review of attachment 215394 [details] [review]:

Looks good, thanks!
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-06-01 14:42:05 UTC 
Attachment 215394 [details] pushed as d9a602f - icon-theme: Allow symbolic GFileIcons