After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676196 - range: use a CSS margin to shrink the trough component
range: use a CSS margin to shrink the trough component
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-16 21:40 UTC by Cosimo Cecchi
Modified: 2012-05-17 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
range: remove commented out code (1.08 KB, patch)
2012-05-16 21:40 UTC, Cosimo Cecchi 		committed Details | Review
range: read and use CSS margin values for the trough component (5.25 KB, patch)
2012-05-16 21:40 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-05-16 21:40:48 UTC 
This will allow us to remove another big part of Adwaita's overrides.
Comment 1 Cosimo Cecchi 2012-05-16 21:40:51 UTC 
Created attachment 214214 [details] [review]
range: remove commented out code

We wouldn't need any detail anyway, since we use a progressbar style
class for the progress part of GtkRange.
Comment 2 Cosimo Cecchi 2012-05-16 21:40:53 UTC 
Created attachment 214215 [details] [review]
range: read and use CSS margin values for the trough component

Many themes want to render the trough background/stroke thinner than the
full height/width (which is constructed around the value of the
'slider-width' style property).
Read and apply the CSS margin from the theme on the trough component, so
that themes can make it smaller at their will without the need to
override the render_background, render_frame and render_activity methods
of GtkThemingEngine.
Comment 3 Cosimo Cecchi 2012-05-17 13:43:05 UTC 
Attachment 214214 [details] pushed as fb968e6 - range: remove commented out code
Attachment 214215 [details] pushed as e32da24 - range: read and use CSS margin values for the trough component

Ack-ed by Benjamin on IRC.