After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676137 - Frei0r filter plugins have a default value, but minimum and maximum are set to -G_MAX_DOUBLE and G_MAX_DOUBLE respectively.
Frei0r filter plugins have a default value, but minimum and maximum are set t...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.36
Other Linux
: Normal trivial
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-16 00:58 UTC by Mathieu Duponchelle
Modified: 2012-05-23 00:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mathieu Duponchelle 2012-05-16 00:58:55 UTC
I can see in gst/frei0r/gstfrei0r.c that :

g_object_class_install_property (gobject_class, count++,
g_param_spec_double (prop_name, param_info->name,
param_info->explanation, -G_MAXDOUBLE, G_MAXDOUBLE, def,
G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));

Would there be a way to get the "real" minimum and maximum, or would we need to maintain an array and specify them manually ?

With a plugin like letterB0xed, for example, the accepted values range from 0.0 to 1.0, any other values causes segfaults in my application.
Comment 1 Sebastian Dröge (slomo) 2012-05-16 06:48:51 UTC
frei0r plugins don't allow to specify a minimum and maximum value unfortunately. This would need to be added to the frei0r spec.

Maintaining a list of plugins with their min/max values for properties inside GStreamer is not feasable.
Comment 2 Mathieu Duponchelle 2012-05-16 16:47:56 UTC
Thanks for that quick answer, I have made a report on frei0r bugtracker directly, if I find time I'll try to produce a patch directly in libfrei0r, have a good day :)
Comment 3 Mathieu Duponchelle 2012-05-16 16:59:32 UTC
http://www.piksel.no/projects/frei0r/ticket/35
Comment 4 Mathieu Duponchelle 2012-05-20 08:09:04 UTC
After an answer on the above bug report, I can see that the specs actually specify a range [0, 1] for the double properties :

http://frei0r.dyne.org/codedoc/html/group___p_a_r_a_m___t_y_p_e.php#g05eba906a358ba2e64a0bd55e8a287c9

If needed I'll do a patch for this, but I don't have the git repo here and that's such a trivial change that I'll indulge myself in asking you to do it :)
Good news anyway, cause I badly needed maximum and minimum for the keyframe implementation in pitivi.
Have another nice day :)
Comment 5 Sebastian Dröge (slomo) 2012-05-22 09:20:25 UTC
commit b409e9602fd052608066c3b312bba795fbb0b10e
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue May 22 11:10:24 2012 +0200

    frei0r: Double properties are supposed in the range [0.0, 1.0]
    
    Fixes bug #676137.
Comment 6 Mathieu Duponchelle 2012-05-23 00:03:20 UTC
Thanks a lot.