After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676022 - 0.10: Problems to decode JPEG images
0.10: Problems to decode JPEG images
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal blocker
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-14 11:18 UTC by Jens Georg
Modified: 2012-06-07 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Sample image (858.78 KB, image/jpeg)
2012-05-14 11:18 UTC, Jens Georg 		  Details
videodecoder: do not do timestamp arithmetic from an invalid timestamp (1.05 KB, patch)
2012-06-07 15:51 UTC, Vincent Penquerc'h 		committed Details | Review

Description Jens Georg 2012-05-14 11:18:50 UTC 
Created attachment 213992 [details]
Sample image

0.10 branch @ a784306f72d7a9ec798fdc1e38e9860ec6f863bc

Trying to decode the attached JPEG with playbin2:

ERROR: from element /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0/GstDecodeBin2:decodebin20/GstJpegDec:jpegdec0: Failed to decode JPEG image
Additional debug info:
gstjpegdec.c(1335): gst_jpeg_dec_handle_frame (): /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0/GstDecodeBin2:decodebin20/GstJpegDec:jpegdec0:
Decode error #55: Not a JPEG file: starts with 0xff 0xec
Comment 1 Tim-Philipp Müller 2012-05-14 11:44:20 UTC 
Looks like a regression introduced by the port to GstVideoDecoder.
Comment 2 Tim-Philipp Müller 2012-05-15 08:36:16 UTC 
Some of the issues have been fixed now, but some still remain. Needs more testing.

e.g. junk(?) after EOI leads to an error being thrown, while it should just be ignored/skipped until an SOI marker is found again.
Comment 3 Tim-Philipp Müller 2012-05-17 08:07:04 UTC 
The regressions I mentioned before have been fixed now with Edward's latest patches.

There's still an issue with jpeg-in-multipart though: the file from bug #616346 plays fine in playbin2 with the last release (well, shows some picture, there's no timing info of course), but not with git.
Comment 4 Tim-Philipp Müller 2012-05-17 09:28:48 UTC 
Fixes in 0.10 also need to be forward-ported to master.
Comment 5 Vincent Penquerc'h 2012-06-07 15:51:49 UTC 
Created attachment 215855 [details] [review]
videodecoder: do not do timestamp arithmetic from an invalid timestamp

This fixes untimestampped buffers from being rejected by the segment clipper.
Comment 6 Vincent Penquerc'h 2012-06-07 15:55:48 UTC 
This fixes playback of the file in bug #616346.

Current git also checked to display the flower image with edward's patches, so closing.