After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675996 - Disable 'reread CD' menu item while already rereading a CD
Disable 'reread CD' menu item while already rereading a CD
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-13 22:43 UTC by Christophe Fergeau
Modified: 2012-05-14 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't set 'reread CD' sensitivity in _stop() (1.84 KB, patch)
2012-05-13 22:43 UTC, Christophe Fergeau 		committed Details | Review
Disable 'reread CD' menu item while already rereading a CD (1.83 KB, patch)
2012-05-13 22:43 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2012-05-13 22:43:08 UTC 
This patch series makes sure the "reread CD" menu item is disabled
when the CD is already being reread.
Comment 1 Christophe Fergeau 2012-05-13 22:43:10 UTC 
Created attachment 213970 [details] [review]
Don't set 'reread CD' sensitivity in _stop()

_stop() is resetting the sensitivity of the "reread CD" menu entry
to TRUE, but nothing in this file disables it. This commit removes
this code assuming the sensitivity would be changed in the same file
if there was a matching 'disable sensitivity' call.
Comment 2 Christophe Fergeau 2012-05-13 22:43:12 UTC 
Created attachment 213971 [details] [review]
Disable 'reread CD' menu item while already rereading a CD
Comment 3 Ross Burton 2012-05-14 08:24:55 UTC 
Review of attachment 213970 [details] [review]:

Yeah, fair enough.
Comment 4 Ross Burton 2012-05-14 08:25:17 UTC 
Review of attachment 213971 [details] [review]:

Looks good.
Comment 5 Christophe Fergeau 2012-05-14 14:07:30 UTC 
Attachment 213970 [details] pushed as 9cb8fb9 - Don't set 'reread CD' sensitivity in _stop()
Attachment 213971 [details] pushed as b0e05a9 - Disable 'reread CD' menu item while already rereading a CD