After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675571 - (out) or (inout) annotation possibly missing for gtk_menu_item_toggle_size_request
(out) or (inout) annotation possibly missing for gtk_menu_item_toggle_size_re...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-06 16:27 UTC by Phil Clayton
Modified: 2013-04-29 06:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add inout annotation (869 bytes, patch)
2012-11-15 18:57 UTC, David King 		committed Details | Review

Description Phil Clayton 2012-05-06 16:27:10 UTC 
For gtk_menu_item_toggle_size_request, the parameter requisition is reported as an IN pointer by introspection.  However, it appears that toggle-size-request signal handlers write to *requisition, so this should probably be marked (out), or even (inout) if, in principle, a signal handler may read it too.
Comment 1 David King 2012-11-15 18:57:44 UTC 
Created attachment 229076 [details] [review]
add inout annotation

The default handler (gtk_real_menu_item_toggle_size_request) does:

*requisition = 0;

so I guess that (inout) is the right annotation, which is what the attached patch adds.
Comment 2 Matthias Clasen 2013-04-29 04:01:03 UTC 
Review of attachment 229076 [details] [review]:

ok
Comment 3 David King 2013-04-29 06:22:05 UTC 
Comment on attachment 229076 [details] [review]
add inout annotation

Pushed to master as commit 402985077bec898c2d30734cea5ee3d31ad1d7b4.