After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675400 - Use XDG dirs instead of $HOME
Use XDG dirs instead of $HOME
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-03 19:48 UTC by William Jon McCann
Modified: 2012-06-02 02:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Read pangorc from XDG_CONFIG_HOME (2.46 KB, patch)
2012-05-11 00:13 UTC, Matthias Clasen
none Details | Review
Read pangox.aliases from XDG_CONFIG_HOME (1.20 KB, patch)
2012-05-11 00:14 UTC, Matthias Clasen
none Details | Review
Read pangox.aliases from XDG_CONFIG_HOME (1.20 KB, patch)
2012-06-02 02:42 UTC, Matthias Clasen
committed Details | Review
Read pangorc from XDG_CONFIG_HOME (2.46 KB, patch)
2012-06-02 02:42 UTC, Matthias Clasen
committed Details | Review

Description William Jon McCann 2012-05-03 19:48:53 UTC
Currently we load .pangorc and .pango.aliases files from HOME. These should probably prefer the XDG Base dirs instead.

	  filename = g_build_filename (home, ".pangorc", NULL);
      filename = g_strconcat (home,
			      G_DIR_SEPARATOR_S ".pango.aliases",
			      NULL);
Comment 1 Matthias Clasen 2012-05-11 00:13:57 UTC
Created attachment 213842 [details] [review]
Read pangorc from XDG_CONFIG_HOME

Look for the rcfile in $XDG_CONFIG_HOME/pango/pangorc
instead of ~/.pangorc.
Comment 2 Matthias Clasen 2012-05-11 00:14:10 UTC
Created attachment 213843 [details] [review]
Read pangox.aliases from XDG_CONFIG_HOME

Change the X fontmap code to look for the aliases file
in $XDG_CONFIG_HOME/pango/pangox.aliases instead of
~/.pangox_aliases
Comment 3 Behdad Esfahbod 2012-05-28 02:23:49 UTC
The pangox stuff better just go to /dev/null...  The rest, if you tested it and it works, should go in.
Comment 4 Matthias Clasen 2012-06-02 02:42:25 UTC
The following fixes have been pushed:
ca6555a Read pangox.aliases from XDG_CONFIG_HOME
926aa9b Read pangorc from XDG_CONFIG_HOME
Comment 5 Matthias Clasen 2012-06-02 02:42:28 UTC
Created attachment 215475 [details] [review]
Read pangox.aliases from XDG_CONFIG_HOME

Change the X fontmap code to look for the aliases file
in $XDG_CONFIG_HOME/pango/pangox.aliases instead of
~/.pangox_aliases
Comment 6 Matthias Clasen 2012-06-02 02:42:31 UTC
Created attachment 215476 [details] [review]
Read pangorc from XDG_CONFIG_HOME

Look for the rcfile in $XDG_CONFIG_HOME/pango/pangorc
instead of ~/.pangorc.