After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675399 - Mention that the image was at least exported in the close warning dialog.
Mention that the image was at least exported in the close warning dialog.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.8.0
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 596901 678662 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-05-03 19:40 UTC by Ken Moffat
Modified: 2012-10-07 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
confirm exported pref (5.64 KB, patch)
2012-05-06 11:34 UTC, Mikael Magnusson
rejected Details | Review
mention exported (1.70 KB, patch)
2012-05-06 11:35 UTC, Mikael Magnusson
none Details | Review

Description Ken Moffat 2012-05-03 19:40:21 UTC
I'm processing raw files through the ufraw plug-in.  When I export as jpeg the file is correctly saved, but when I then try to close the image I *sometimes* get the dialog "Save the changes to image 'Untitled' before closing?"..

Trying to provoke it so I could post the actual question from the dialog, the first export and close was ok.  On the second attempt I used file->save as (old habits die hard), corrected that to export, then got the dialog.  I have a suspicion that erroneously trying file->save (and not saving that because I didn't want an export) might be part of the cause.  On the third attempt I did a correct file->export, close but I still got the dialog.

Hmm, closed the gimp, reopened, processed a fourth image, file->export, file-> close without the spurious dialog.  Perhaps opening the Save As dialog sets an indicator which never gets cleared if you cancel that, and Export 

Tried a freshly opened gimp, new image, didn't export it.  Correctly got the dialog when I used file->close (good!), so exported, still got the dialog when I again used file->close.
Comment 1 Michael Natterer 2012-05-04 22:08:34 UTC
The files are *exported* not *saved*, this is completely intentional,
see http://gui.gimp.org/index.php/Save_%2B_export_specification
Comment 2 Ken Moffat 2012-05-05 00:34:36 UTC
Yes, they *are* exported.  Please stand back a moment and think of the user experience.  I've spent time manipulating the image, then exported it.  Now, I (soemtimes) get a message saying I've not *saved* it.  That makes me think the export wasn't completed.  Most of the time, the change is small enough that I have no wish to create an xcf version of the working file.

If I get this message that I've not saved a file every time I close after exporting, the message is just noise.  Now, if it told me that I'd *only* exported the image but not saved it, that might be useful.
Comment 3 Michael Natterer 2012-05-05 17:03:52 UTC
Now that is actually a useful suggestion, thank you. Reopening for
further discussion.
Comment 4 Mikael Magnusson 2012-05-06 11:34:23 UTC
Created attachment 213545 [details] [review]
confirm exported pref

This patch adds a preference that allows you to close exported images without saving. The wording of the help text can probably be improved a bit.
Comment 5 Mikael Magnusson 2012-05-06 11:35:34 UTC
Created attachment 213546 [details] [review]
mention exported

This patch adds a blurb to the confirmation dialog that the image has been exported. I don't know if the quit dialog should also be modified (it unconditionally asks for confirmation regardless of the existing preference).
Comment 6 peter sikking 2012-05-07 11:20:03 UTC
adding the info that a file has been exported in the confirmation dialog is a good one, I agree.

the extra pref for "Confirm closing of unsaved but exported images"  is something that is tempting for users in these switchover weeks, but just dangerous beyond that.

quit is implicitly 'close all then quit' and close all should have the same diligence as a single close.
Comment 7 Michael Natterer 2012-05-09 23:13:33 UTC
Fixed in master and gimp-2-8:

commit 062d38d141907d095b92e7a1adc05cd1bc870be2
Author: Michael Natterer <mitch@gimp.org>
Date:   Thu May 10 01:10:27 2012 +0200

    Bug 675399 - Mention that the image was at least exported in the close...
    
    If the image was exported, mention it in the close warning dialog.
    (cherry picked from commit 57d4680ab3ecb748dfbdd9b9a0995da2f4ef01fa)
Comment 8 Michael Schumacher 2012-06-27 22:15:35 UTC
*** Bug 678662 has been marked as a duplicate of this bug. ***
Comment 9 Michael Natterer 2012-10-07 16:22:19 UTC
*** Bug 596901 has been marked as a duplicate of this bug. ***