GNOME Bugzilla – Bug 675246
Strings appear untranslated
Last modified: 2012-05-03 09:51:06 UTC
Created attachment 213215 [details] Screenshot of the problem Some translated strings still appear untranslated: - In the account editor, push the Birthday button of a XMPP account, the title of the appearing date selector appears untranslated. This is because in src/empathy-accounts.c the textdomain() call is after g_set_application_name(), not before. - The application name in empathy-accounts --help. This is because in g_option_context_new(), you need to use the _() macro, not N_(). (this isn't *that* important, just struck me while fixing the previous one :))
Created attachment 213216 [details] [review] Fix the problems mentioned above
Review of attachment 213216 [details] [review]: Thanks for the patch. While you're add it any chance you could check and fix the other files as well ? :) src/empathy-auth-client.c src/empathy-av.c src/empathy-call.c src/empathy-chat.c src/empathy-debugger.c src/empathy.c
Sure. Meanwhile, I have checked the docs again, and turns out I was wrong: in g_option_context_new(), the N_() macro is correct, the translation domain needs to be set with g_option_context_set_translation_domain(). So let's see what's wrong with these: src/empathy-auth-client.c : nothing src/empathy-av.c : textdomain() should be before g_set_application_name(), g_option_context_set_translation_domain() needs to be added src/empathy-call.c : same as the previous src/empathy-chat.c : g_option_context_set_translation_domain() needs to be added src/empathy-debugger.c : same as empathy-av src/empathy.c : textdomain() should be before g_set_application_name(), g_option_group_set_translation_domain() needs to be called to localize the descriptions of the no-connect and start-hidden options. src/empathy-accounts.c : same as empathy-av.c
Created attachment 213348 [details] [review] Fix all the problems listed in the previous comment
Merged; thanks a lot for your work on this!