After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675234 - Fix DLNA bitrate calculation using presets
Fix DLNA bitrate calculation using presets
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-01 12:22 UTC by Jens Georg
Modified: 2012-05-17 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Fix DLNA bitrates using presets (11.22 KB, patch)
2012-05-01 12:22 UTC, Jens Georg 		committed Details | Review
core: Lower MPEG2 bitrates (1.64 KB, patch)
2012-05-01 12:22 UTC, Jens Georg 		committed Details | Review
core: Lower MP3 bitrate (1.17 KB, patch)
2012-05-01 12:22 UTC, Jens Georg 		committed Details | Review
core: AAC_ISO_320 -> AAC_ADTS_320 (2.92 KB, patch)
2012-05-01 15:37 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2012-05-01 12:22:11 UTC 
This fixes:
 - The abysmal MPEG2 quality introduced with the encodebin switch
 - A work-around for bug 672439 by cunningly excluding mpeg2enc from the party
 - Lower the bitrates for MPEG2 video and MP3

With the preset in 7c2029c my core i5 uses 60%-80% CPU while still looking way
better than what we had before.

Luis's preset from
https://github.com/luisbg/rygel/blob/9a95d1d2a16ea1a6cc11dedb17c463adbf344c6a/data/presets/ffenc_mpeg2video.prs
of course looks better but uses 160% CPU here so I think that's a no-go. I
think we should provide a default with a good trade-off between picture
quality and CPU use.

Changes in dependency: GStreamer 0.10.36 for gst_preset_set_app_dir
Comment 1 Jens Georg 2012-05-01 12:22:14 UTC 
Created attachment 213196 [details] [review]
core: Fix DLNA bitrates using presets

Also cunningly work around bgo#672439 by not providing a preset for
mpeg2enc.
Comment 2 Jens Georg 2012-05-01 12:22:17 UTC 
Created attachment 213197 [details] [review]
core: Lower MPEG2 bitrates
Comment 3 Jens Georg 2012-05-01 12:22:20 UTC 
Created attachment 213198 [details] [review]
core: Lower MP3 bitrate
Comment 4 Jens Georg 2012-05-01 15:37:43 UTC 
Created attachment 213218 [details] [review]
core: AAC_ISO_320 -> AAC_ADTS_320

Since muxing into streamable mp4 seems to be a bit broken, move to
ADTS-framed AAC instead. This is required by DLNA anyway.
Comment 5 Jens Georg 2012-05-17 09:49:59 UTC 
Attachment 213196 [details] pushed as 2bb5ad3 - core: Fix DLNA bitrates using presets
Attachment 213197 [details] pushed as a7d50b5 - core: Lower MPEG2 bitrates
Attachment 213198 [details] pushed as a001f25 - core: Lower MP3 bitrate
Attachment 213218 [details] pushed as 7aeb69c - core: AAC_ISO_320 -> AAC_ADTS_320