GNOME Bugzilla – Bug 675213
Various introspection issues
Last modified: 2012-05-04 01:43:58 UTC
Created attachment 213166 [details] [review] Register RestParam as boxed type. Passing --warn-all to g-ir-scanner reveals several issues, some of which have straightforward fixes. RestParam should probably be registered as a boxed type, there are several missing annotations, one function (oauth_proxy_new_echo_proxy) isn't documented at all, and a argument names on a couple prototypes don't match docs.
Created attachment 213167 [details] [review] Assorted introspection fixes
Review of attachment 213166 [details] [review]: Looks good.
Review of attachment 213167 [details] [review]: Looks good. In the echo proxy documentation the correct terminology is an OAuth Echo proxy, and link that to http://www.scribd.com/doc/26707268/. Apart from that looks great! I'm no GIR expert so I hoping someone else would look at it, thanks very much.
> Apart from that looks great! I'm no GIR expert so I hoping someone else would > look at it, thanks very much. I think the remaining issues fall into two categories. The first is that RestParams is really just a hash table, but g-i doesn't support this (bug #581686). It might be best to just skip RestParams and use the type annotation to switch all the RestParams arguments to GHashTables. The other issue is that some of the some functions (like rest_proxy_call_continuous) don't take a GDestroyNotify for the user data, but none of the existing scopes make sense (see https://live.gnome.org/GObjectIntrospection/Annotations#Callbacks_Scope_Types).
commit 8ea1394b7bf9338ad0a8f504920e43698afb97d3 Author: Evan Nemerson <evan@coeus-group.com> Date: Thu May 3 18:36:46 2012 -0700 assorted introspection fixes Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=675213 commit b449fd9067cc4267057ef751032dcf0225e6e51d Author: Evan Nemerson <evan@coeus-group.com> Date: Mon Apr 30 23:01:36 2012 -0700 rest-param: register RestParam as boxed type.