After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675018 - Git compiled gjs is incompatible with system version
Git compiled gjs is incompatible with system version
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-28 12:11 UTC by Giovanni Campagna
Modified: 2012-05-24 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Rename GjsDBus to GjsPrivate (2.65 KB, patch)
2012-04-28 12:11 UTC, Giovanni Campagna
committed Details | Review
GDBus: fix NotImplementedError message (1013 bytes, patch)
2012-04-28 12:12 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-04-28 12:11:35 UTC
See downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=817261

This is because I found another way to solve it, that doesn't involve backporting the patch.

(It still makes sense to backport it, because it solves the unversioned .so in /lib64 problem)
Comment 1 Giovanni Campagna 2012-04-28 12:11:56 UTC
Created attachment 213020 [details] [review]
Rename GjsDBus to GjsPrivate

GjsDBus is likely to be present in system directories too, if
an older version of gjs is installed, and this can cause symbol
conflicts between system libgjs-gdbus.so and libgjs.so.
Also, it could be that some day we want to do something else with
it.
Comment 2 Giovanni Campagna 2012-04-28 12:12:20 UTC
Created attachment 213021 [details] [review]
GDBus: fix NotImplementedError message

Single quotes must be used, or the method_name concatenation is not
recognized.

Just something I found passing by.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-04-28 18:24:40 UTC
Review of attachment 213021 [details] [review]:

Hah, silly.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-04-28 18:24:57 UTC
Review of attachment 213020 [details] [review]:

ugggh. I'd rather have Colin review this one.
Comment 5 Giovanni Campagna 2012-04-29 16:27:31 UTC
Comment on attachment 213021 [details] [review]
GDBus: fix NotImplementedError message

Attachment 213021 [details] pushed as e694a2e - GDBus: fix NotImplementedError message
Comment 6 Matthias Clasen 2012-05-24 18:31:10 UTC
The patch fixed the problem for me. 
Colin was talking about something akin to GI_PRELOAD to fix the system vs jhbuild problem.
Comment 7 Colin Walters 2012-05-24 18:33:59 UTC
Review of attachment 213020 [details] [review]:

Oh, that's a nice solution, looks good!
Comment 8 Giovanni Campagna 2012-05-24 18:39:57 UTC
Attachment 213020 [details] pushed as 4727b9c - Rename GjsDBus to GjsPrivate